Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with backbone 1.1.0 #33

Open
Darksoulsong opened this issue Jan 28, 2014 · 3 comments
Open

Not compatible with backbone 1.1.0 #33

Darksoulsong opened this issue Jan 28, 2014 · 3 comments

Comments

@Darksoulsong
Copy link

Backbone version: 1.1.0
Underscore vs: 1.5.2
RequireJS version: 2.1.9
Google Chrome: 32.0.1700.76 m

I had to change a bunch of lines where the options are not passed as parameter to the initialize function to some views (almost all of them). Is this project still being supported?

Example:
From:

var Header = Datagrid.Header = Backbone.View.extend({
  tagName: 'thead',

  initialize: function() {
    this.columns = options.columns;
    this.sorter  = options.sorter;
  },

to:

    var Header = Datagrid.Header = Backbone.View.extend({
      tagName: 'thead',

  initialize: function(options) {
    this.columns = options.columns;
    this.sorter  = options.sorter;
  },

And this happens on every view definition.

The sorting is not working too.

I'm using it on a requirejs setup, included as a shim.

@loicfrering
Copy link
Owner

Hi @Darksoulsong, thanks for reporting. The project is still maintained and used: I have on my todo to work on 1.1.0 compatibility very soon, I'll keep you updated.

@Darksoulsong
Copy link
Author

@loicfrering TYVM. I'm looking forward to it. =)

@loicfrering
Copy link
Owner

@Darksoulsong I tested Backbone.Datagrid v0.4.0-beta.1 with Backbone 1.1.*, everything looks ok: I fixed the issue with this.options in e89b257.

Let me know if you encounter any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants