From 42c330c0e9e5afada21a36b6cd38b09363774656 Mon Sep 17 00:00:00 2001 From: Robin Andersson Date: Tue, 13 Jun 2023 10:06:55 +0200 Subject: [PATCH] [HWORKS-586] Upgrade great expectations to 0.14.13 (#1442) --- .../test/ruby/spec/helpers/featurestore_validation_helper.rb | 2 +- .../hopsworks/common/featurestore/FeaturestoreConstants.java | 1 + .../datavalidationv2/suites/ExpectationSuiteDTO.java | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hopsworks-IT/src/test/ruby/spec/helpers/featurestore_validation_helper.rb b/hopsworks-IT/src/test/ruby/spec/helpers/featurestore_validation_helper.rb index d20feafa2c..d896f72b31 100644 --- a/hopsworks-IT/src/test/ruby/spec/helpers/featurestore_validation_helper.rb +++ b/hopsworks-IT/src/test/ruby/spec/helpers/featurestore_validation_helper.rb @@ -95,7 +95,7 @@ def generate_template_validation_report() template_validation_result = generate_template_validation_result() { "evaluationParameters": "{}", - "meta": "{\"great_expectations_version\":\"0.14.12\",\"expectation_suite_name\":\"expecations_suite_101\",\"run_id\":{\"run_time\":\"2022-03-11T13:06:24.481236+00:00\",\"run_name\":null},\"batch_kwargs\":{\"ge_batch_id\":\"0d0afc48-a13c-11ec-b113-020f94a1da7f\"},\"batch_markers\":{},\"batch_parameters\":{},\"validation_time\":\"20220311T130624.481059Z\",\"expectation_suite_meta\":{\"great_expectations_version\":\"0.14.12\"}}", + "meta": "{\"great_expectations_version\":\"0.14.13\",\"expectation_suite_name\":\"expecations_suite_101\",\"run_id\":{\"run_time\":\"2022-03-11T13:06:24.481236+00:00\",\"run_name\":null},\"batch_kwargs\":{\"ge_batch_id\":\"0d0afc48-a13c-11ec-b113-020f94a1da7f\"},\"batch_markers\":{},\"batch_parameters\":{},\"validation_time\":\"20220311T130624.481059Z\",\"expectation_suite_meta\":{\"great_expectations_version\":\"0.14.13\"}}", "results": [template_validation_result], "success": false, "statistics": "{\"evaluated_expectations\":7,\"successful_expectations\":5,\"unsuccessful_expectations\":2,\"success_percent\":71.42857142857143}", diff --git a/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/FeaturestoreConstants.java b/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/FeaturestoreConstants.java index 43bb460609..d8945c9079 100644 --- a/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/FeaturestoreConstants.java +++ b/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/FeaturestoreConstants.java @@ -157,4 +157,5 @@ private FeaturestoreConstants() { public static final String UNEXPECTED_PERCENT_KEY = "unexpected_percent"; public static final String PARTIAL_UNEXPECTED_LIST_KEY = "partial_unexpected_list"; public static final String UNEXPECTED_PERCENT_NONMISSING_KEY = "unexpected_percent_nonmissing"; + public static final String GREAT_EXPECTATIONS_META = "{\"great_expectations_version\": \"0.14.13\"}"; } diff --git a/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/datavalidationv2/suites/ExpectationSuiteDTO.java b/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/datavalidationv2/suites/ExpectationSuiteDTO.java index 21c918e946..2ff174c819 100644 --- a/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/datavalidationv2/suites/ExpectationSuiteDTO.java +++ b/hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/datavalidationv2/suites/ExpectationSuiteDTO.java @@ -17,6 +17,7 @@ package io.hops.hopsworks.common.featurestore.datavalidationv2.suites; import io.hops.hopsworks.common.api.RestDTO; +import io.hops.hopsworks.common.featurestore.FeaturestoreConstants; import io.hops.hopsworks.common.featurestore.datavalidationv2.expectations.ExpectationDTO; import io.hops.hopsworks.persistence.entity.featurestore.featuregroup.datavalidationv2.Expectation; import io.hops.hopsworks.persistence.entity.featurestore.featuregroup.datavalidationv2.ExpectationSuite; @@ -40,7 +41,7 @@ public class ExpectationSuiteDTO extends RestDTO { private String dataAssetType = null; private String expectationSuiteName; private List expectations; - private String meta = "{\"great_expectations_version\": \"0.14.12\"}"; + private String meta = FeaturestoreConstants.GREAT_EXPECTATIONS_META; private String geCloudId = null; private ValidationIngestionPolicy validationIngestionPolicy = ValidationIngestionPolicy.ALWAYS; private boolean runValidation = true;