Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

Config URL IP instead of localhost #18

Open
ourcontact opened this issue Sep 12, 2020 · 6 comments
Open

Config URL IP instead of localhost #18

ourcontact opened this issue Sep 12, 2020 · 6 comments

Comments

@ourcontact
Copy link

ourcontact commented Sep 12, 2020

Instead of localhost, why not list the IP?
Is localhost used in code for writing making remote headless access an issue with creating config.json through Web interface?
Also is port configurable without recompile?

Current
[>] SSDP server running on !
[i] HarmonySpan's Configuration Menu is available at http://localhost:8060/config

Proposed
[>] SSDP server running on !
[i] HarmonySpan's Configuration Menu is available at http://:8060/config

Example
[>] SSDP server running on 192.168.1.129!
[i] HarmonySpan's Configuration Menu is available at http://192.168.1.129:8060/config

@logantgt
Copy link
Owner

Thanks for opening the issue!

I've been meaning to fix this and resolve a few other issues - hopefully I'll be able to get around to this tomorrow.

Thank you so much for the support!

@ourcontact
Copy link
Author

Thank you for a great tool!

As you are aware, but it took me a while to discover, the localhost is also hardcoded as full path instead of relative in the config.html so when I tried remote web access to configure, the config.json wasn't updated. I used remote X Firefox ( and vi ) to edit the config.json on my headless server and after figuring out a few more mistakes I made, everything is working great now!

@logantgt
Copy link
Owner

Sounds fantastic! If you'd feel comfortable, I would greatly appreciate it if you made a PR so I could merge these changes. Thank you again for your support!

@ourcontact
Copy link
Author

ourcontact commented Sep 16, 2020

I'll give it a shot, I need to use Git& GitHub for code and make sure I can work from your source and compile. But have never quite taken the time to figure git all out.

So please be patient and understanding with me ;)

@logantgt
Copy link
Owner

All good! Let me know if you need any help!

@logantgt
Copy link
Owner

Feel free to add the changes you mentioned in #17 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants