[fixed] Call parent.removeChild only if parent exists (reactjs#778)

loganscharen · Nov 15, 2019 · 5dffbf2 · 5dffbf2
1 parent 684d3b8
commit 5dffbf2
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/components/Modal.js b/src/components/Modal.js
@@ -174,7 +174,16 @@ class Modal extends Component {
   removePortal = () => {
     !isReact16 && ReactDOM.unmountComponentAtNode(this.node);
     const parent = getParentElement(this.props.parentSelector);
-    parent.removeChild(this.node);
+    if (parent) {
+      parent.removeChild(this.node);
+    } else {
+      // eslint-disable-next-line no-console
+      console.warn(
+        'React-Modal: "parentSelector" prop did not returned any DOM ' +
+          "element. Make sure that the parent element is unmounted to " +
+          "avoid any memory leaks."
+      );
+    }
   };
 
   portalRef = ref => {