-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customise POD defnition #39
Comments
Hi @Iyappanj, thanks for opening the issue. I'm going to transfer it to the kubernetes provider repository. First up for the Pod customization we have the apiVersion: v1
kind: Pod
spec:
- containers:
name: devpod # make sure you name this exactly `devpod`
resources: {} # resources go here As for the second question, are you looking in all namespaces? |
Hi @pascalbreuninger, Thanks for taking time in answering the questions. I already tried with the POD_MANIFEST_TEMPLATE, as per the example provided here - https://github.com/loft-sh/devpod-provider-kubernetes/blob/main/hack/provider/pod-manifest-template.yaml. But after adding the pod manifest, I am unable to create a workspace. the error I get is as below 09:32:44 info unmarshal pod template: error unmarshaling JSON: json: cannot unmarshal string into Go value of type v1.Pod without the pod template, it's working fine I also read that I can specify the pod resources in provider.yaml but doing so will affect all the new pods that I will create. So I am trying to change it in the devcontainer.json as below. but nothing seems changing with the devcontainer.json. Do you have any reference for it ? containerEnv": { |
Are you on an older version of the kubernetes provider? If so, please make sure to update at least to
This needs to be configure on the provider level, not in the |
@pascalbreuninger instead of doing it on provider level, I want to restrict the resources on workspace level. that is the reason I was trying to achieve it on the devcontainer.json. you have any idea how we can achieve it on wprkspace level ? Adding to it, when do a help for the command like below, I don't have a description that guides me with the args that -o accepts. If we have a guide that helps us with the arguments that a option accepts would be great. devpod provider set-options kubernetes --help Usage: Flags: Global Flags: |
There's no such thing directly. Instead it'll use the latest provider options before starting a workspace.
Fair enough, we'll need to generate some documentation for this. For the time being you can always find the options in the |
This sounds quite limiting. A lot of those options (service account, resources, labels, etc...) are something one want to customise per workspace. Having to reconfigure your provider each time is not really convenient. Imo this could live in the "customizations": {
"type": "object",
"description": "Tool-specific configuration. Each tool should use a JSON object subproperty with a unique name to group its customizations."
}, Would that be something the team is open to change? I'd be eager use that as a contribution starting point if so. |
@b4nst That's definitely something we've discussed quite a bit and we don't have a definitive stance on it because it doesn't come without complexity and drawbacks:
All this doesn't mean we won't ever add this, I just want to convey the effort and thoughts that need to go into it |
Is your feature request related to a problem?
I cannot find detailed documents w.r.t Depod to go through. the only document what I go throught is https://devpod.sh/docs/what-is-devpod
Which solution do you suggest?
Which alternative solutions exist?
Additional context
The text was updated successfully, but these errors were encountered: