Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic placeholders in the POD_MANIFEST_TEMPLATE #35

Open
fw8 opened this issue Dec 1, 2023 · 1 comment
Open

Add support for dynamic placeholders in the POD_MANIFEST_TEMPLATE #35

fw8 opened this issue Dec 1, 2023 · 1 comment

Comments

@fw8
Copy link

fw8 commented Dec 1, 2023

Is your feature request related to a problem?

Yes, the current implementation of the POD_MANIFEST_TEMPLATE lacks support for dynamic placeholders, making it challenging to handle varying workspace paths (and other settings) in the devpod container.

Which solution do you suggest?

I propose adding support for interpolation/templating in the pod config. This enhancement would enable users to use placeholders or variables, allowing for dynamic insertion of values such as the path to the workspace.

Which alternative solutions exist?

Currently, a separate provider instance must be created for each project, which then points to the corresponding static template.

Additional context

Example use case:

In scenarios where bind mounts in the workspace of the devpod container with a dind sidecar are necessary, the workspace must also be mounted in the dind container. The path to the workspace varies based on the workspace name, making it challenging to set up consistent configurations.

Introducing templating or placeholders in the POD_MANIFEST_TEMPLATE would greatly enhance flexibility and ease of configuration, benefiting users facing similar challenges.

For example:

volumeMounts:
- mountPath: /workspaces/${WORKSPACE}
  name: dind
  subPath: devpod/0
@fw8 fw8 changed the title Add Support for Dynamic Placeholders in the POD_MANIFEST_TEMPLATE Add support for dynamic placeholders in the POD_MANIFEST_TEMPLATE Dec 1, 2023
@pascalbreuninger pascalbreuninger added the enhancement New feature or request label Apr 18, 2024
@pascalbreuninger pascalbreuninger transferred this issue from loft-sh/devpod Apr 18, 2024
@pascalbreuninger
Copy link
Member

Moved to provider repository, hopefully it'll get more visibility here

@deniseschannon deniseschannon removed the enhancement New feature or request label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants