Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CDK deployment #18

Merged
merged 22 commits into from
Nov 29, 2024
Merged

Implement CDK deployment #18

merged 22 commits into from
Nov 29, 2024

Conversation

pinzon
Copy link
Contributor

@pinzon pinzon commented Nov 26, 2024

Motivation

It would be good to have a deployment method that uses CDK to show of our CloudFormation support.

Changes

Unfortunately in the time allotted, I could not get a seamless deploy with the frontend building working. We have code to do this in our -ext test repo, however I elected for a two-stage CDK deployment, building the frontend app in between. This is because the frontend app depends on the backend APIGW REST API URL, which is not known until the application is deployed. I have therefore split the deploy process into two: the backend stack, and the statically hosted frontend HTML/JS/CSS.

  • Add bin/deploy_cdk.sh script to execute the two step deployment process
  • Update lambda handlers to return valid CORS responses
  • Update the README with CDK instructions

Notes

The deploy process is dependent on LocalStack having been bootstrapped already, and as of 2024-11-29 CORS still needs to be disabled for the LS instance as per the README.

Copy link

github-actions bot commented Nov 26, 2024

@pinzon pinzon changed the title wip: implement backent into cdk wip: implement backend into cdk Nov 26, 2024
@simonrw simonrw changed the title wip: implement backend into cdk Implement CDK deployment Nov 29, 2024
@simonrw simonrw marked this pull request as ready for review November 29, 2024 15:46
@simonrw simonrw requested a review from HarshCasper November 29, 2024 15:46
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@HarshCasper HarshCasper merged commit 39650fa into main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants