-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CDK deployment #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Preview for this PR: https://ls-e8hq3s7ab0g40.sandbox.localstack.cloud/cloudfront/bf1c5b39/ |
pinzon
changed the title
wip: implement backent into cdk
wip: implement backend into cdk
Nov 26, 2024
They are used for the integration tests
HarshCasper
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be good to have a deployment method that uses CDK to show of our CloudFormation support.
Changes
Unfortunately in the time allotted, I could not get a seamless deploy with the frontend building working. We have code to do this in our -ext test repo, however I elected for a two-stage CDK deployment, building the frontend app in between. This is because the frontend app depends on the backend APIGW REST API URL, which is not known until the application is deployed. I have therefore split the deploy process into two: the backend stack, and the statically hosted frontend HTML/JS/CSS.
bin/deploy_cdk.sh
script to execute the two step deployment processNotes
The deploy process is dependent on LocalStack having been bootstrapped already, and as of 2024-11-29 CORS still needs to be disabled for the LS instance as per the README.