Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assembly files to freertos_port_files() #76

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

eivindbergem
Copy link
Contributor

Some ports have assembly as well as C files.

@schteve
Copy link
Collaborator

schteve commented Oct 3, 2024

Apologies for taking a while on this. Seems like an easy one to accept - it makes sense to include assembly (and probably other port files) in the list so the rebuild happens when changing them. Two things:

  1. Could you remove the eprintln!()? I guess it's probably a debug thing left in.
  2. Does it make sense to add both .s and .S files? I think the string check is case sensitive.

@eivindbergem
Copy link
Contributor Author

1. Could you remove the `eprintln!()`? I guess it's probably a debug thing left in.

Will do.

2. Does it make sense to add both .s and .S files? I think the string check is case sensitive.

I did a search in the FreeRTOS kernel repo and there are both .s and .S. I'll add matching for both.

@schteve
Copy link
Collaborator

schteve commented Oct 21, 2024

Thanks!

@schteve schteve merged commit e32d69a into lobaro:master Oct 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants