Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Autumn-Aton infinite loop on lack of zone access #2182

Closed
yojimboslaw opened this issue Dec 19, 2024 · 3 comments
Closed

[BUG] Autumn-Aton infinite loop on lack of zone access #2182

yojimboslaw opened this issue Dec 19, 2024 · 3 comments

Comments

@yojimboslaw
Copy link

https://imgur.com/LsfLr1p
Garbo is seeing that rock salt is very expensive and would like to get some, but can't because I don't have access to that version of the Orcish Frat House. I confirmed this item in particular was the cause by restarting kolmafia, listing rock salt at mall min with a 5/day limit, rerunning the script to update the value accordingly, and having it handle that choice adventure correctly.

The script reads like nonsense to me (I'm sure it's well-written, but it's out of my wheelhouse), so I can't confirm whether or not this is a regexp that needs to be modified due to the recent KoL change to choice.php's html or whether there's just lacking logic for handling zone access, but one of those two seems to most likely be the issue.

@gausie
Copy link
Contributor

gausie commented Dec 19, 2024

Just a note that

The script reads like nonsense to me (I'm sure it's well-written, but it's out of my wheelhouse)

is a really antisocial way of writing “I took a look to try to fix it but am afraid it is beyond my current skill level” or something.

@yojimboslaw
Copy link
Author

yojimboslaw commented Dec 19, 2024 via email

@pstalcup
Copy link
Contributor

Resolved by #2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants