Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicate is used on low value item drop yellow ray, due to book of facts pocket wish value #2085

Open
Rinn opened this issue Sep 9, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Rinn
Copy link
Member

Rinn commented Sep 9, 2024

Duplicate should be deferred for yellow rays until all book of facts pocket wishes are completed, as we are wasting the item dupes on monsters with lower value items.

From this same log if we had waited to dupe we would have instead hit a toxic beastie and got 12 toxic globules.

This is from testing #2082 which adds mctwist:

Session Log

09:12:09  [621] Shadow Rift (Desert Beach)
09:12:09  Preference lastEncounter changed from Adjust your Parka to shadow devil
09:12:09  Encounter: shadow devil
09:12:09  Preference _shadowRiftCombats changed from 10 to 11
09:12:09  Round 0: Rinnith wins initiative!
09:12:09  Preference cosmicBowlingBallReturnCombats changed from 24 to 23
09:12:09  Round 0: Rinnith casts DO AN EPIC MCTWIST!!
09:12:09  Preference _epicMcTwistUsed changed from false to true
09:12:09  Round 1: Rinnith casts DUPLICATE!
09:12:09  You gain 58 Meat.
09:12:09  Preference _sourceTerminalDuplicateUses changed from 0 to 1
09:12:09  Round 2: Rinnith casts SPIT JURASSIC ACID!
09:12:09  You acquire an effect: Everything Looks Yellow (99)
09:12:09  Round 3: Rinnith wins the fight!
09:12:09  After Battle: You pause and think about KoL Con VI, when you helped carry the kegs to an afterparty. You didn't know you were so strong!
09:12:09  After Battle: You gain 10 Beefiness
09:12:09  After Battle: The Government surveys the scene from atop the throne and sighs.
09:12:09  After Battle: Tricksy Granada tiptoes out of her hiding place and gives you some meat.
09:12:10  You gain 10 Meat.
09:12:10  After Battle: Any biology textbook will tell you that the shadow devil has a secret bone in its ankle, that if you stick it up your nose, it will grant you a wish.
09:12:10  Preference _bookOfFactsWishes changed from 1 to 2
09:12:10  You acquire an item: pocket wish
09:12:10  You acquire an item: shadow flame
09:12:10  You acquire an item: shadow flame
09:12:10  You acquire an item: shadow flame
09:12:10  You acquire an item: shadow flame
@Rinn Rinn added the good first issue Good for newcomers label Sep 9, 2024
@horrible-little-slime
Copy link
Contributor

Another core issue here is that there are a few zones where we might go to YR, not encounter the monster we "want" to YR, and then do it anyways (because our code naively estimates the value of these YRs). Not every zone is like shadow realm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants