Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Marginal MPA issue (very very negative items value) #1825

Open
Aliisza opened this issue Mar 15, 2024 · 4 comments · May be fixed by #1845
Open

[BUG] Marginal MPA issue (very very negative items value) #1825

Aliisza opened this issue Mar 15, 2024 · 4 comments · May be fixed by #1845
Assignees
@pstalcup

Comments

@Aliisza
Copy link

Aliisza commented Mar 15, 2024

Describe the bug
Is anyone else getting very wrong marginal MPA printouts? Mine are looking like this everytime:

This run of garbo, across 612 turns you generated 6,175,275 meat, with 4,899,854 raw meat and 1,275,421 from items
So far today, across 613 turns you generated 5,672,942 meat, with 4,243,954 raw meat and 1,428,988 from items
Outliers:
Marginal MPA: 4,796.06 [raw] + -7,906,481.95 [items] (0 [outliers]) = -7,901,685.89 [total] (-7,901,685.89 [w/ outliers])

To Reproduce
Steps to reproduce the behavior:
I'm not actually certain what is causing the issue. Just that ever since it started tracking marginal MPA again. My items value has always been some massive multi-millions negative meat value in the ITEMS catagory.

Expected behavior
A clear and concise description of what you expected to happen.

Session Log
Attach a full KoLMafia session log from the day you encountered the bug. Include details about when in the log the bug occurred to help developers rapidly find the error. Copy and paste any associated red text printed to the gCLI during this error.
aliisza_20240314.txt

Additional context
Add any other context about the problem here. Does this always happen post-loop, but never pre-loop? Did this start happening when you got some particular IotM?
@Aliisza Aliisza changed the title [BUG] [BUG] Marginal MPA issue (very very negative items value) Mar 15, 2024
@horrible-little-slime
Copy link
Contributor

Per testing by @Tokoeka this is related to clan stash handling

@Aliisza
Copy link
Author

Aliisza commented Mar 18, 2024

Per testing by @Tokoeka this is related to clan stash handling

Is it something more logs would help to fix? Or something someone's already working on?

Merged
@Tokoeka
Copy link
Contributor

Tokoeka commented Apr 4, 2024

Still occuring with this fix- from browsing the code, my guess would be that no 0 turns remaining calc for marginal MPA occurs until the trackMarginalMpa(0); added in endSession(), which does not resolve the issue as endSession is called outside the withStash invocation in index.ts. I think this could be resolved by moving either the trackMarginalMpa(0); call or endSession() itself to being the final item of the withStash invocation (line 529 of index.ts), but not sure which would be preferable

@Tokoeka Tokoeka reopened this Apr 4, 2024
@Tokoeka
Copy link
Contributor

Tokoeka commented Apr 4, 2024

Tested adding trackMarginalMpa(0) as the final item of withStash, and it appears to have worked. will add a PR

@Tokoeka Tokoeka linked a pull request Apr 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pstalcup pstalcup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

track marginal mpa (0) as last item in withStash Tokoeka/garbage-collector
4 participants
@pstalcup @Aliisza @horrible-little-slime @Tokoeka