Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Campground Gear in Small #1357

Merged
merged 17 commits into from
Oct 2, 2023
Merged

Get Campground Gear in Small #1357

merged 17 commits into from
Oct 2, 2023

Conversation

Alium58
Copy link
Member

@Alium58 Alium58 commented Sep 10, 2023

Description

Goal is to make hardcore small run without getting beaten up

Changes to accomplish this:

  1. Limit ML safety limit to 50 when in HC small. Uncapped is just too much
  2. Always in HC get gear from dirt in campground. Only zone with a cape.
  3. If beaten up in Norma,l get gear from dirt
  4. If beaten up in HC or Normal, eventually get gear from tall grass
  5. Due to above changes, allow flyering again

How Has This Been Tested?

D1 of a hardcore seal clubber small run went well. Didn't get beaten up
D2 got beaten up at L12 war boss. Added them to monsters to always major attack, reran, and killed with no issue
Finished with 2/570

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

@Alium58 Alium58 marked this pull request as ready for review September 11, 2023 12:43
@Malibu-Stacey Malibu-Stacey added the enhancement New feature or request label Sep 14, 2023
@Alium58
Copy link
Member Author

Alium58 commented Sep 19, 2023

finished a couple more HC small runs without getting beaten up. Also confirm pref backup and restoring is working properly now, had a few typos in that section of it.

@Alium58 Alium58 self-assigned this Sep 20, 2023
@Alium58 Alium58 requested review from a team September 20, 2023 18:41
Copy link
Member

@dsimich dsimich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can uncomment the Very Tall Grass section once Mafia gets that info

@dsimich dsimich merged commit 8ad87f9 into main Oct 2, 2023
2 checks passed
@dsimich dsimich deleted the small_campground_gear branch October 2, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants