Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local CI-like testing script #35

Open
lo48576 opened this issue Apr 11, 2024 · 2 comments
Open

Update local CI-like testing script #35

lo48576 opened this issue Apr 11, 2024 · 2 comments
Labels
low-priority Low priority

Comments

@lo48576
Copy link
Owner

lo48576 commented Apr 11, 2024

Current Makefile.toml is unmaintained for a while, so needs an update.

Most broken part I think is clippy lint with --deny warnings. Basically, newer clippy versions will behave better (i.e. have less false-negative and more false-positive), so failure with clippy of MSRV and stable channel are not critical if beta or nightly clippy succeeds. However, current test script requires no warnings with MSRV clippy. This is not ideal since this will reject some harmless or even better source codes.

Another problematic part is the less intuitive notation of the current Makefile.toml file.
What is @@decode(FEATURES,,,--features=${FEATURES})?
Why is it necessary to read the manual just to change condition = { rust_version = { equal = "$MSRV" } } to condition = { channels = ["nightly"] }?
How can I judge whether non-latest MSRV satisfies condition = { channels = ["stable"] } or not, without checking documentation and issue tickets?

I'd like to maintain more readable script, but still I prefer declarative ones...

@lo48576
Copy link
Owner Author

lo48576 commented Apr 11, 2024

Note: I currently don't use online CI service (free plan) because the extensive tests for multiple toolchain versions and multiple features combinations are too heavy. They will consume time budgets very quickly.

@lo48576
Copy link
Owner Author

lo48576 commented Sep 11, 2024

Status update: I currently own CI servers in my homelab, so I can run CI (Woodpecker) by pushing the repo to git server in the homelab.
Maybe I'll remove the almost unmaintained Makefile.toml and use it.

@lo48576 lo48576 added the low-priority Low priority label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low priority
Projects
None yet
Development

No branches or pull requests

1 participant