Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Disable plugin action for unexpected syntaxes #17

Closed
wants to merge 1 commit into from

Conversation

Kristinita
Copy link

@Kristinita Kristinita commented Jan 12, 2018

1. Summary

I make, that css_to_cass command works only for SASS and Stylus.

2. Argumentation

CSS to SASS work for SASS and Stylus syntaxes. But for another syntaxes users don't need this plugin. And in another syntaxes (Python, Ruby, HTML and so on) users can use another actions for Ctrl+V (⌘v for Mac) shortcut.

3. Steps to reproduce

I copy any text → I paste this text, use Ctrl+V for:

  1. Stylus or SASS syntax,
  2. Any another syntax.

4. Behavior before pull request

For SASS/Stylus syntax:

key evt: control+v
command: css_to_sass
True

(or False instead of true)

For any another syntax:

key evt: control+v
command: css_to_sass
True

5. Behavior after pull request

For SASS/Stylus syntax:

key evt: control+v
command: css_to_sass
True

For any another syntax:

key evt: control+v
command: paste

6. Technical explanation

See:

7. Supported syntaxes

In Package Control site I find these syntaxes for Stylus and SASS:

If another syntaxes exists:

    we need add scopes for them.

8. Testing environment

  • Windows 10 Enterprise LTSB 64-bit EN,
  • Sublime Text Build 3143,
  • SASS 2015.06.09.15.02.18,
  • Stylus 2017.12.19.12.00.23,
  • CSS to SASS Converter 1.2.2

Thanks.

@lnikell lnikell closed this Jan 15, 2018
@Kristinita
Copy link
Author

@lnikell , I'm sorry, I paste description for another pull request. I don't understand how it happened 😕 .

Please, review pull request now.

Thanks.

@Kristinita
Copy link
Author

@lnikell , ping.

Thanks.

@Kristinita
Copy link
Author

@lnikell ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants