Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] LLDB test failures related to zlib #123479

Open
boomanaiden154 opened this issue Jan 18, 2025 · 3 comments · May be fixed by #123489
Open

[CI] LLDB test failures related to zlib #123479

boomanaiden154 opened this issue Jan 18, 2025 · 3 comments · May be fixed by #123489
Assignees
@boomanaiden154
Labels
github:workflow lldb

Comments

@boomanaiden154
Copy link
Contributor

When running lldb tests in the new premerge system on Github Actions, we're seeing some test failures due to a missing/misconfigured zlib:

2025-01-18T03:38:02.9058314Z FAIL: lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp (1587 of 2651)
2025-01-18T03:38:02.9059816Z ******************** TEST 'lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp' FAILED ********************
2025-01-18T03:38:02.9061028Z Exit Code: 1
2025-01-18T03:38:02.9061285Z 
2025-01-18T03:38:02.9061478Z Command Output (stderr):
2025-01-18T03:38:02.9061975Z --
2025-01-18T03:38:02.9065413Z RUN: at line 6: /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp
2025-01-18T03:38:02.9072765Z + /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp
2025-01-18T03:38:02.9079018Z RUN: at line 7: /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib
2025-01-18T03:38:02.9084673Z + /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib
2025-01-18T03:38:02.9088241Z ld.lld: error: --compress-debug-sections: LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
2025-01-18T03:38:02.9089218Z 
2025-01-18T03:38:02.9089389Z --
2025-01-18T03:38:02.9089590Z 
2025-01-18T03:38:02.9089752Z ********************

Doesn't look like it should be too complicated to fix, just wanted to create a bug so I don't lose track of the issue and forget to fix it until I see the failure again.
@boomanaiden154 boomanaiden154 self-assigned this Jan 18, 2025
@boomanaiden154 boomanaiden154 added infrastructure Bugs about LLVM infrastructure and removed new issue labels Jan 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 18, 2025

@llvm/issue-subscribers-infrastructure

Author: Aiden Grossman (boomanaiden154)

When running lldb tests in the new premerge system on Github Actions, we're seeing some test failures due to a missing/misconfigured zlib: ``` 2025-01-18T03:38:02.9058314Z FAIL: lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp (1587 of 2651) 2025-01-18T03:38:02.9059816Z ******************** TEST 'lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp' FAILED ******************** 2025-01-18T03:38:02.9061028Z Exit Code: 1 2025-01-18T03:38:02.9061285Z 2025-01-18T03:38:02.9061478Z Command Output (stderr): 2025-01-18T03:38:02.9061975Z -- 2025-01-18T03:38:02.9065413Z RUN: at line 6: /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp 2025-01-18T03:38:02.9072765Z + /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp 2025-01-18T03:38:02.9079018Z RUN: at line 7: /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib 2025-01-18T03:38:02.9084673Z + /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib 2025-01-18T03:38:02.9088241Z ld.lld: error: --compress-debug-sections: LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time 2025-01-18T03:38:02.9089218Z 2025-01-18T03:38:02.9089389Z -- 2025-01-18T03:38:02.9089590Z 2025-01-18T03:38:02.9089752Z ******************** ```

Doesn't look like it should be too complicated to fix, just wanted to create a bug so I don't lose track of the issue and forget to fix it until I see the failure again.

@boomanaiden154
Copy link
Contributor Author

Looks like there are a couple issues here:

  • The CI container LLVM is not built with ZLib
  • The test defaults to using the system LLD if LLD isn't also built. But we check that we have zlib at build time, not that the system LLD being used by lit has been built with ZLib.
  • LLDB does not have a dependency on lld in the premerge setup.

The last one seems intentional. The first two should probably be fixed.

boomanaiden154 added a commit to boomanaiden154/llvm-project that referenced this issue Jan 19, 2025
@boomanaiden154
[Github] Add Zlib at build time to CI container
8a12f88 
This patch adds zlib at build time to the CI container. This is needed to make
an lldb test pass that defaults to using the system lld if it is not explicitly
enabled in LLVM_ENABLE_PROJECTS.

Fixes llvm#123479 (by fixing the proximal cause).
@boomanaiden154 boomanaiden154 linked a pull request Jan 19, 2025 that will close this issue
Open
@EugeneZelenko EugeneZelenko added lldb github:workflow and removed infrastructure Bugs about LLVM infrastructure labels Jan 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 19, 2025

@llvm/issue-subscribers-lldb

Author: Aiden Grossman (boomanaiden154)

When running lldb tests in the new premerge system on Github Actions, we're seeing some test failures due to a missing/misconfigured zlib: ``` 2025-01-18T03:38:02.9058314Z FAIL: lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp (1587 of 2651) 2025-01-18T03:38:02.9059816Z ******************** TEST 'lldb-shell :: SymbolFile/DWARF/x86/debug-names-compressed.cpp' FAILED ******************** 2025-01-18T03:38:02.9061028Z Exit Code: 1 2025-01-18T03:38:02.9061285Z 2025-01-18T03:38:02.9061478Z Command Output (stderr): 2025-01-18T03:38:02.9061975Z -- 2025-01-18T03:38:02.9065413Z RUN: at line 6: /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp 2025-01-18T03:38:02.9072765Z + /__w/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution -c -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o --target=x86_64-pc-linux -gdwarf-5 -gpubnames /__w/llvm-project/llvm-project/lldb/test/Shell/SymbolFile/DWARF/x86/debug-names-compressed.cpp 2025-01-18T03:38:02.9079018Z RUN: at line 7: /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib 2025-01-18T03:38:02.9084673Z + /opt/llvm/bin/ld.lld /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp.o -o /__w/llvm-project/llvm-project/build/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/debug-names-compressed.cpp.tmp --compress-debug-sections=zlib 2025-01-18T03:38:02.9088241Z ld.lld: error: --compress-debug-sections: LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time 2025-01-18T03:38:02.9089218Z 2025-01-18T03:38:02.9089389Z -- 2025-01-18T03:38:02.9089590Z 2025-01-18T03:38:02.9089752Z ******************** ```

Doesn't look like it should be too complicated to fix, just wanted to create a bug so I don't lose track of the issue and forget to fix it until I see the failure again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boomanaiden154 boomanaiden154

Labels
github:workflow lldb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Github] Add Zlib at build time to CI container boomanaiden154/llvm-project
3 participants
@EugeneZelenko @boomanaiden154 @llvmbot