Init commit for sql dialect #319

carlguo866 · 2023-01-31T22:53:34Z

No description provided.

include/sql/SQLDialect.h

include/sql/SQLDialect.td

include/sql/SQLOps.h

include/sql/SQLOps.td

lib/sql/CMakeLists.txt

wsmoses · 2023-02-02T05:21:12Z

lib/sql/Dialect.cpp

@@ -0,0 +1,27 @@
+//===- PolygeistDialect.cpp - Polygeist dialect ---------------*- C++ -*-===//


rename to sql?

wsmoses · 2023-02-02T05:21:18Z

lib/sql/Ops.cpp

@@ -0,0 +1,40 @@
+//===- PolygeistOps.cpp - BFV dialect ops ---------------*- C++ -*-===//
+//


rename to sql?

ftynse · 2023-02-08T14:05:00Z

test/polygeist-opt/sql.mlir

+    %q = "sql.select"() {column = ["data"], table = "mytable"} : () -> index
+    %h = "sql.execute"(%q) : (index) -> index
+    %res = "sql.get_result"(%h, %c0) {column = "data"} : (index, index) -> i32


For this to work, you need to call allowUnknonwnOperations in the dialect initializer.

Is that needed? These operations are registered in the dialect?

carlguo866 · 2023-02-14T19:30:14Z

Including add_mlir_doc(SQLDialect -gen-dialect-doc SQLDialect SQL/) and add_mlir_doc(SQLOps -gen-op-doc SQLOps SQL/) give the following error:

CMake Error at /home/carl/Polygeist/llvm-project/mlir/cmake/modules/AddMLIR.cmake:200 (add_custom_target):
add_custom_target cannot create target "-gen-dialect-docDocGen" because
another target with the same name already exists. The existing target is a
custom target created in source directory
"/home/carl/Polygeist/include/polygeist". See documentation for policy
CMP0002 for more details.
Call Stack (most recent call first):
/home/carl/Polygeist/include/sql/CMakeLists.txt:2 (add_mlir_doc)

CMake Error at /home/carl/Polygeist/llvm-project/mlir/cmake/modules/AddMLIR.cmake:200 (add_custom_target):
add_custom_target cannot create target "-gen-op-docDocGen" because another
target with the same name already exists. The existing target is a custom
target created in source directory
"/home/carl/Polygeist/include/polygeist". See documentation for policy
CMP0002 for more details.
Call Stack (most recent call first):
/home/carl/Polygeist/include/sql/CMakeLists.txt:3 (add_mlir_doc)

wsmoses · 2023-03-03T19:01:47Z

CMakeLists.txt

@@ -1,110 +0,0 @@
-cmake_minimum_required(VERSION 3.10)


Can we leave this file

wsmoses · 2023-11-14T21:30:00Z

tools/cgeist/driver.cc

@@ -73,7 +73,9 @@
 #include <fstream>

 #include "polygeist/Dialect.h"
+#include "sql/SQLDialect.h"


have these inside of #ifdef ENABLE_SQL

you're going to need to in cmake, if enable_sql then add an enable sql in c

(see POLYGEIST_ENABLE_CUDA for an example)

carlguo866 requested review from wsmoses and ftynse January 31, 2023 22:53