Alt bot party members leaving the group

[Grimfeather]

Describe the bug
Sometimes when I log in with one of my characters, alt bot party members will leave the party.
it looks like the character I was previously logged in with stays in the party, the others leave.

Commit hash
AzerothCore rev. abd9b4ebb862 2024-10-30 21:43:42 +0800 (Playerbot branch)

To Reproduce
Steps to reproduce the behavior:
Log in and out with your characters

Expected behavior
bots remain in the party

Video
https://youtu.be/zRyZ6LWjWO0

Desktop (please complete the following information):

• OS: Windows 10

Additional context

AiPlayerbot.BotAutologin = 1

[noisiver]

I can confirm this. If I log out with the character I'm currently using and log in one of the other bots that was in my party this will happen. Sometimes it gets stuck in a loop where bots log in and out constantly. Typing leave in party chat to disband the group before changing characters is a way to get around it until it can be fixed.

[noisiver]

We're not talking about the dungeon finder.

[Grimfeather]

Please check the video. This is not related to the dungeon finder.

[EricksOliveira]

Sorry. Miss click

[EricksOliveira]

Problem occurs due to the master. When you enter a Character without the Leader, the other bots kite and only the character with the Leader remains. When you enter the character who is the Party leader, notice that the others do not leave the party.

[noisiver]

We've established that. The bots are supposed to pass lead to the new master, not leave the group.

[EricksOliveira]

I may have broken this function in this pull.
https://github.com/liyunfan1223/mod-playerbots/pull/616/files

[zhangbo8418]

I may have broken this function in this pull. https://github.com/liyunfan1223/mod-playerbots/pull/616/files

I think it is correct logic that if a player goes offline, the robot in the team should leave the team. Otherwise, the robot will always be in the team and cannot be invited by other players. However, there should be a delay to prevent the team from disbanding due to players disconnecting.

[noisiver]

That's not quite right. The group doesn't disband when you log out, nor should it. What should happen is if you go offline, they will too but remain in the group. If you log into one of the other characters in the same group they will be given leader by the other bots when they log in.

If you actually make it disband the group when you log out that'll be absolutely horrible. The number of times I have to relog every day would be torture if I have to keep adding and inviting them over and over again. It worked fine before, I got leader when I logged onto another character.

[zhangbo8418]

That's not quite right. The group doesn't disband when you log out, nor should it. What should happen is if you go offline, they will too but remain in the group. If you log into one of the other characters in the same group they will be given leader by the other bots when they log in.

If you actually make it disband the group when you log out that'll be absolutely horrible. The number of times I have to relog every day would be torture if I have to keep adding and inviting them over and over again. It worked fine before, I got leader when I logged onto another character.

You're obviously only thinking about yourself, what if multiple players use it at different times? Is the robot always occupied by you even when you are offline? If players stop playing, the bots will become a bunch of useless data because no one can bring them online.

[noisiver]

Now who's thinking about themselves? They used to pass lead and that's it, they didn't leave the group, and it shouldn't be default. It could be configurable.

[noisiver]

The majority of users are the only players on their server or play with a few select friends. I'm certain plenty of them would find it very annoying to have the bots leave your group whenever you log out, especially since it's not uncommon to have to relog. Having to invite the bots again after every relog is just wrong. As said, it could be configurable but it shouldn't be enforced that they leave the group.

[Grimfeather]

Inside dungeons it becomes a problem that they leave the group.
I switch characters for lots of reasons.

[zhangbo8418]

The majority of users are the only players on their server or play with a few select friends. I'm certain plenty of them would find it very annoying to have the bots leave your group whenever you log out, especially since it's not uncommon to have to relog. Having to invite the bots again after every relog is just wrong. As said, it could be configurable but it shouldn't be enforced that they leave the group.

So I said you only consider playing by yourself. Random robots are public resources. The normal logic is that the team should be disbanded after you exit the game (it should not be disbanded immediately to prevent some accidental disconnections), and the robots in the team should get their own rights. It is convenient for other players to form teams, which is also in line with normal player behavior. If you just play by yourself, of course it would be more convenient to bind them to you, but this is an online game after all, so the players have no control over it. If they give up the game, a bunch of bound robots will become useless data.

[Grimfeather]

I made this report specifically for alt bots. please don't bring up random bots, it makes things confusing.

[zhangbo8418]

I made this report specifically for alt bots. please don't bring up random bots, it makes things confusing.

I don't know how 100 real players on your server solve the bot occupation problem.

[zhangbo8418]

I made this report specifically for alt bots. please don't bring up random bots, it makes things confusing.

There are many players who just try it out and never log in to the game again, which results in a large number of robots being occupied and unable to be teamed up with other players.

[Grimfeather]

alt bots, my alt bots, nobody else will be able to use them. you're talking about random bots. different issue, those are indeed shared. not what I'm reporting here.

[EricksOliveira]

I have a slight guess as to what it might be. I made some adjustments but I haven't had time to test it yet. I believe that this week I can add an update for testing.

[noisiver]

I made this report specifically for alt bots. please don't bring up random bots, it makes things confusing.

There are many players who just try it out and never log in to the game again, which results in a large number of robots being occupied and unable to be teamed up with other players.

People can't use your altbots. That's the definition of altbot. Other characters on your account(s).

[zhangbo8418]

I made this report specifically for alt bots. please don't bring up random bots, it makes things confusing.

There are many players who just try it out and never log in to the game again, which results in a large number of robots being occupied and unable to be teamed up with other players.

People can't use your altbots. That's the definition of altbot. Other characters on your account(s).

I know, but this will affect random robots, because in previous versions, random robots will not be released and will always be in the team. Many players just try it and stop logging in, resulting in a large number of random robots being occupied.

[noisiver]

The ideal solution is to make it configurable. Either they leave the group when you log out or they stay in it. Ideally it should differentiate between rndbots and altbots. altbots leaving the group on logout by default is just a horrible idea though. I have no real opinion on rndbots because I don't use them for anything but battlegrounds and arenas. It's not that hard to make a SQL query that removes those bots from the group either until something has been changed. If a character hasn't been logged in for X amount of time then delete their group.

[EricksOliveira]

#702

[Grimfeather]

In a 5-man party it's not so bad, I can make the character I want to switch to leader before switching. the other bots will log out right away when I do that though. If I'm in a dungeon only the character I switched to and the one I controlled before will still be in the dungeon. But alright, I can summon the others to me. So no big deal.

But now, if I'm in a raid. It totally sucks. If the character I want to switch to is in a different group, on a different account, it becomes very annoying. Bots log out, get teleported to the nearest GY, I have to figure out who was in the raids, re-invite them 1 by 1. This is just not ok. If I get to a boss and want to switch characters for that boss fight, everything goes to hell.