Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction creation on the group page #26

Open
nmorduch opened this issue Mar 1, 2014 · 7 comments
Open

Transaction creation on the group page #26

nmorduch opened this issue Mar 1, 2014 · 7 comments
Assignees

Comments

@nmorduch
Copy link
Member

nmorduch commented Mar 1, 2014

Not immediately, I imagine, but I would eventually like to get the transaction creation and editing to be done from within the group_detail page. Transaction editing should probably actually be on any page where there is a log of transactions.

@melinath melinath self-assigned this Mar 29, 2014
melinath added a commit that referenced this issue Mar 29, 2014
…ction updates.

Touches on #26, #16, and philosophical discussions.
melinath added a commit that referenced this issue Mar 30, 2014
… of them.

Touches on #26, but still need support for locking created transactions to a certain party/category on that page.
@melinath
Copy link
Member

Technically resolved before 12f4a94 - but do we want to set some defaults if creating on party/category pages?

@melinath
Copy link
Member

@harrislapiroff we also need to have better form behavior. "Sharers" should only be visible if it's an even split, and the per-member fields should only be visible if it's a manual split. Not to mention that the flow needs a lot of work...

@melinath melinath assigned harrislapiroff and unassigned melinath Mar 30, 2014
@nmorduch nmorduch added this to the Launch milestone Mar 31, 2014
@nmorduch
Copy link
Member Author

Oooh yeah set it by default to be in that category or for that party.

@harrislapiroff we'll need to hinge a show/hide on which piece of a select is selected, which sounds complicated form-wise.

@melinath
Copy link
Member

melinath commented Apr 1, 2014

@nmorduch - for that party? Like... paid to that party? Or paid by that party? Or it depends whether it's a member or not?

@nmorduch
Copy link
Member Author

nmorduch commented Apr 1, 2014

Paid by if a member, paid to if not? Though that does get a bit confusing. Maybe it is a little silly to have that. Maybe actually we should only have transaction creation on the group page?

@melinath
Copy link
Member

melinath commented Apr 2, 2014

It sounds like you might be concerned that things are magically and confusingly happening... We can still display the whole form, and just have the category/party set by default. (So you'd still be able to change them to something else.) Or we could disable the fields, but still display them.

@nmorduch
Copy link
Member Author

nmorduch commented Apr 2, 2014

Right, but as a user I don't think I'm going to want to input from a person/category page with the idea that this new entry belongs to that person/category. I'm going to be looking at those pages for information, but when I'm inputting things it's probably going to be with a pile of receipts belonging to a few people.

Based on that idea, I think it only makes sense to have transaction creation on every page if it's generally small and collapsed at the top, and feels as unchanging as the header. And then the problem would be if you added something from a specific page but it didn't belong on that page, and then it wouldn't add to the log you could see, so we'd need a notification about it. I think that right now I might prefer it only to be on the main group page.

@nmorduch nmorduch removed this from the Launch for testing milestone May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants