Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Warnings Related to Spectre Mitigation #47

Open
nibanks opened this issue Jan 8, 2023 · 1 comment
Open

Build Warnings Related to Spectre Mitigation #47

nibanks opened this issue Jan 8, 2023 · 1 comment

Comments

@nibanks
Copy link
Contributor

nibanks commented Jan 8, 2023

With the latest release, most build warnings went away, except for the following:

https://github.com/nibanks/msh3/actions/runs/3868034900/jobs/6593213121#step:7:118

D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(461): warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(458): message : index 'p' range checked by comparison on this line [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(461): message : feeds call on this line [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
...
@nibanks
Copy link
Contributor Author

nibanks commented Jan 8, 2023

Oh, I found one other warning (not spectre related):
https://github.com/nibanks/msh3/actions/runs/3868034900/jobs/6593213177#step:7:114

D:\a\msh3\msh3\ls-qpack\lsqpack.c(4222,5): warning C4061: enumerator 'LQRHS_ERROR' in switch of enum 'lsqpack_read_header_status' is not explicitly handled by a case label [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]
D:\a\msh3\msh3\ls-qpack\lsqpack.h(340,6): message : see declaration of 'lsqpack_read_header_status' [D:\a\msh3\msh3\build\ls-qpack\ls-qpack.vcxproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant