Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error display messes up the play/pause on scroll mechanism #389

Open
yonatan opened this issue Sep 3, 2018 · 4 comments
Open

Error display messes up the play/pause on scroll mechanism #389

yonatan opened this issue Sep 3, 2018 · 4 comments

Comments

@yonatan
Copy link
Contributor

yonatan commented Sep 3, 2018

It's more noticeable on shorter/low-res screens. To reproduce the issue you can paste

throw '\n'.repeat(33)

into a dweet and then scroll down.

I'm guessing Waypoint.Inview can't handle dynamic changes to elements' heights, or it needs to be notified somehow? It seems to reset when more dweets are loaded.

@joeytwiddle
Copy link
Collaborator

joeytwiddle commented Sep 3, 2018

Is it always a problem? Even with only 5 rows? How about 10 rows?

(I have a sort-of wish to start loading the next set of dweets earlier anyway. I don't really like having to wait and watch them load. It would be good if it started while I was viewing the last 2 dweets on the current page. Although ... it might disrupt their framerates!)
Edit: I mean it could start loading early, not playing early!

@yonatan
Copy link
Contributor Author

yonatan commented Sep 3, 2018

I noticed it on a 1024x768 screen with https://www.dwitter.net/d/9636 (might have been zoomed in a little too). It wasn't too bad, but still noticeable. You can resize your browser window to try it out.

I wouldn't want more than 1 dweet playing at a time. Some resource-hungry ones already make my browser unresponsive at times.

@lionleaf
Copy link
Owner

lionleaf commented Sep 7, 2018

Nicely caught, thanks for the raising the issue.

I've decided to only show the error messages when editing a dweet (see #373 ). That would make this bug less of a problem, but if you're remixing something with a long error message and then scroll down you would still run into the same problem.

It's been a while since I've looked at the scrolling logic, but I'd expect we could refresh the anchors when an error message change?

@imscary
Copy link
Contributor

imscary commented Sep 8, 2018

This happens also when you are writing a new dweet with a lot of rows and, without publishing it, scrolling down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants