Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate the device Class programmatically #790

Closed
whot opened this issue Oct 16, 2024 · 3 comments
Closed

Generate the device Class programmatically #790

whot opened this issue Oct 16, 2024 · 3 comments

Comments

@whot
Copy link
Member

whot commented Oct 16, 2024

Nothing uses libwacom_get_class() (except for identifying remotes, see #779) but we still have to add it each .tablet file. Since we don't have any known callers we can just generate the value:

  • IntegratedIn=Display -> Cintiq
  • IntegratedIn=Display;System -> ISDV4
  • IntegratedIn= -> Bamboo
@whot whot mentioned this issue Oct 16, 2024
Merged
@redstrate
Copy link
Contributor

I started work on this, but it dawned on me that there's a lot of classes other than Cintiq, ISDV4 and Bamboo. I guess it makes sense to only generate it programmatically if it doesn't have an explicit one defined?

redstrate added a commit to redstrate/libwacom that referenced this issue Oct 16, 2024
@redstrate
Generate the class given in class if not explicitly given (linuxwacom…
a82ee8d 
…#790)

This is still a part of the API, and thus have required even new .tablet
files to fill this out even though it's superseded by IntegratedIn. So
let's generate them programmatically.

This turns devices that are IntegratedIn=Display to the Cintiq class,
IntegratedIn=Display;System into the ISDV4 class, and everything else
into the Bamboo class.
@whot
Copy link
Member Author

whot commented Oct 21, 2024

The only class that currently matters is the WCLASS_REMOTE, all the others are never used for anything (afaik). Many are expired and now pointless anyway (Intuos*, Bamboo, Graphire). So the only ones that "matter" are Cintiq, Intuos5 and ISDV4 - all of which we can auto-assign.

And the remote of course :)

@whot
Copy link
Member Author

whot commented Nov 1, 2024

Fixed in #814

@whot whot closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whot @redstrate