Drop Python 2 support, removed in qBittorrent v4.2.2 #77
Conversation
I'm qBittorrent developer. qbittorrent/search-plugins#84 (comment) Resolves linuxserver#67
|
@thelamer ping |
|
@nemchik ping |
|
Ref: #71 discussion I agree python2 is EOL and many apps have updated to no longer depend on it. That being said it's still available to install in Ubuntu's repos for bionic and having it alongside python3 isn't problematic. It will very likely get removed when we rebase our Ubuntu images to focal. We're waiting on an upstream issue to be fixed. Anyway I'm not against it being removed right now either. It seems like it would only be used by users running custom scripts, and they could use our custom init to get python 2 back if they still require it. I'll bring this up internally and we'll make a determination on it. |
|
Sorry for my ignorance, but even the latest unstable version is still using python2 even though I see in python3 in the docker image... I'm trying to patch on my own, but either I didn't understand how you guys are approaching this fix or there's indeed something going wrong in the releases. |
|
@renannprado Just tested the latest Docker image. qBittorrent is using Python3 as expected. You can take a look at the logs: Make sure you remove all the previous Docker images. docker rmi ... |
Description:
Drop Python 2 support, removed in qBittorrent v4.2.2
I'm qBittorrent developer. We dropped Python 2 support a couple of months ago, it's time to clean up the Docker image.
Benefits of this PR and context:
Resolves #67
Reduces Docker image in 22 MB.
How Has This Been Tested?
Yes. Local build and test.
Source / References:
qbittorrent/search-plugins#84 (comment)