Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improved settings UI #12486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Improved settings UI #12486

wants to merge 1 commit into from

Conversation

clefebvre
Copy link
Member

@clefebvre clefebvre commented Nov 6, 2024

Requires linuxmint/python3-xapp#24

The purpose is to improve the look and feel of the settings application. Some of the ideas are inspired by what has been done in GNOME, KDE and Ubuntu and what's been observed outside of the Linux community.

Rounded sections

Rounded sections make the UI more modern and integrate nicely with the rounded nature of Cinnamon themes. In the screenshot below, the first section is rounded, the second one isn't.

image

The rounded section should look nice in any theme but also be themeable via newly introduced CSS style names.

Subtitles and tooltips hints

Tooltip hints make it more obvious when more info is available.

Subtitles allow us to squeeze in more information. Along with tooltips they can reduce the need for text blocks.

image

Disabled settings vs hidden settings

Cinnamon Settings relies on revealers to show/hide settings which depend on others. Although that's pretty nifty, it makes screenshots less consistent, it's harder to remember when a particular setting is or to find it when looking for it. In general, it's also a bad idea to hide widgets away from the user or having things suddenly pop up.

This PR goes towards showing everything and relying on sensitivity to disable settings which aren't available.

@clefebvre clefebvre changed the title Settings: Rounded sections Improved settings UI Nov 6, 2024
@clefebvre
Copy link
Member Author

Here's a quick prototype to illustrate old vs new class structures and to troubleshoot with Glade:

settings.tar.gz

To run it with Gtk Inspector:

gsettings set org.gtk.Settings.Debug enable-inspector-keybinding true
GTK_DEBUG=interactive python3 ./settings.py

@leigh123linux
Copy link
Contributor

I really dislike the shadow.

image

@clefebvre
Copy link
Member Author

clefebvre commented Nov 6, 2024

We can improve the default CSS. Experiment with it if you have the time and let me know if you find something better.

@clefebvre
Copy link
Member Author

clefebvre commented Nov 6, 2024

Here it is with no shadow.

image

Note: Ignore the bottom border, it has an extra separator which shouldn't be there.

@clefebvre
Copy link
Member Author

Here's an example in GNOME

image

Rounded section, shadows, subtitles and tooltip hint.

@axel358
Copy link
Contributor

axel358 commented Nov 11, 2024

For the Mint-Y style, I also agree that looks better with no shadow. I think subtitles should be preferred over tooltips when possible, as they expose the additional information/context right away to the user. It would also be nice to see a unified settings style between all OS components. xlets and system settings modules use the style shown above, but apps like the file manager use a completely different one

@clefebvre clefebvre changed the title Improved settings UI [WIP] Improved settings UI Nov 27, 2024
@anaximeno
Copy link
Contributor

anaximeno commented Nov 29, 2024

Another point that might be worth looking at, is setting a maximum width for the sections because on bigger screens the description of the option and their action button can be too far away from each other which could lead to more effort trying to understand and modify each setting option:

Captura de ecrã de 2024-11-29 06-50-30

GNOME already has a limit for the width of the sections in settings IIRC.

@JosephMcc
Copy link
Contributor

@anaximeno I'm pretty sure it was like that when we first implemented this style of settings. But people complained that it "didn't" expand to fill the window. I'm also not sure how many people maximize a settings window on a large screen. There is no reason to.

@clefebvre
Copy link
Member Author

Quick note on this: It was postponed to 22.2.

@anaximeno
Copy link
Contributor

@anaximeno I'm pretty sure it was like that when we first implemented this style of settings. But people complained that it "didn't" expand to fill the window.

I see.

I'm also not sure how many people maximize a settings window on a large screen. There is no reason to.

I think it's not too uncommon, generally, you maximize a window if you want to focus on it and avoid whatever is in the background taking your attention, I can see this regularly being the case when you're looking for something in settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants