Option to display non-critical notifications over full-screen apps #10182
Conversation
cs_notifications.py
|
Hello, @Ammako.
The schemas you are looking for are in the cinnamon-desktop package. Specifically the org.cinnamon.desktop.notifications.gschema.xml.in.in file. You could create a PR there and reference it here (and vice versa). An observation on your JavaScript changes. You are using tabs in your changes, when the general convention is spaces. |
|
I used spaces, but I think the github web editor might have been dumb and converted some of it to tabs (I was too lazy to set up git for direct push.) Managed to mess up some of my indentation though, and some other parts of messageTray.js were using tabs already. I left them as-is because I figured it would be best if I didn't touch unrelated parts of the code, but if everything needs to be spaces then I might as well go ahead and fix that too. |
ghost
mentioned this pull request
js/ui/messageTray.js
Outdated
| @@ -1014,6 +1015,8 @@ MessageTray.prototype = { | |||
| this._notification.actor._parent_container.remove_actor(this._notification.actor); | |||
| } | |||
|
|
|||
| let canShowNonCriticalInFullscreen = this._nonCriticalDisplayFullscreen; | |||
There was a problem hiding this comment.
this is not aligned with the other lines
There was a problem hiding this comment.
So annoying lol, I swear it was aligned when I initially made the change. No idea what happened.
ghost
closed this
ghost
mentioned this pull request
#9529
Seems okay here... this is probably not quite ready to merge yet though, because this change requires addingdisplay-noncritical-in-fullscreentoorg.cinnamon.desktop.notifications, and I could not for the life of me figure out how to programmatically add or update this in the cinnamon repo.For testing I manually edited/usr/share/glib-2.0/schemas/org.cinnamon.desktop.notifications.gschema.xmlto add the new key, and recompiled usingglib-compile-schemas. If you'd like to merge then please make sure to update things on your end so the new key can be properly added.