Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] network applet: Add settings for wireless network list. #10076

Closed
wants to merge 2 commits into from

Conversation

boughtonp
Copy link

As per #10001 this adds a couple of settings in relation to the wireless network list.

The first setting replaces the existing constant of 5 before showing the "More" menu.
The second setting allows hiding the list when connected to a network.

@mtwebster mtwebster changed the title network applet: Add settings for wireless network list. [wip] network applet: Add settings for wireless network list. May 31, 2021
@boughtonp
Copy link
Author

Ok, I've updated to use settings via callback.

It still seems to need an applet reload for changed settings to take effect - should that be immediate?

@clefebvre clefebvre changed the title [wip] network applet: Add settings for wireless network list. [WIP] network applet: Add settings for wireless network list. Jun 10, 2022
@mtwebster
Copy link
Member

I'm sorry for this being overlooked - I use filters when going thru pr's and I've neglected to check.

I tried this again, and it's still not updating -

           this.settings.bind("num-visible-networks", this._setNumVisibleNetworks);
           this.settings.bind("hide-other-networks-when-connected", this._setHideOtherNetworksWhenConnected);

These still need the "num_visible_networks" and "hide_other_networks_when_connected" arguments, but with the callbacks after them - see https://github.com/linuxmint/Cinnamon/blob/master/js/ui/settings.js#L344-L355

And to update the actual applet, you would need some method to reconstruct the applet menu, or at least to modify those details that are relevant to the settings, and call this function in those callbacks.

@clefebvre clefebvre closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants