Stop using GTimeVal/g_get_current_time #10043
Conversation
ItzSwirlz
changed the title
|
Why are you removing cinnamon_util_format_date - how is it related to the rest of the pr?? That's needed by a workaround we have in environment.js. |
clefebvre
changed the title
Didn't know that. |
ItzSwirlz
changed the title
mtwebster
changed the title
|
i can't do crap i just rewrote the function using GstDateTime and other stuff the compiler recommended and of course the g_get_real_time cast still makes me want to cry Anyways, test time.. and it still protection faults. dangit. |
ItzSwirlz
changed the title
|
Finally done, tested and recorder works. Apparently it doesn't care if the function is a GstClockTime and it returns a gint64? |
It is Y-2038 unsafe. References: https://developer.gnome.org/glib/stable/glib-Date-and-Time-Functions.html GNOME/gnome-shell@9b7f228 GNOME/gnome-shell@a030c54#diff-3b88f09b111c3c589502e6cdf5bc3be7f1d2fc632e2180542ea570ef6cb67078 Some of GstClock was used: https://developer.gnome.org/gstreamer/stable/GstClock.html
ItzSwirlz
changed the title
ItzSwirlz
changed the title
|
By the way, this is done (don't want to keep racking up the PRs sitting around). It looks like it can merge |
|
You didn't test the hotplug-sniffer change. It segfaults immediately. |
I decided to push through with the cinnamon recorder manually myself. GNOME uses a GDBus friendlier JS recorder which I don't know what everyone's thoughts are since some may prefer JS over C and being closer upstream with GNOME. Anyways, here it is.