Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when not found libffmpegthumbnailer.so #93

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

rb-union
Copy link
Contributor

软件调整环境变量,可能未查找到库,解析接口时,
遗漏判空处理,导致访问越界;
同时调整创建临时图片的方式,改为 QTemporaryDir 的方式.

Log: 修复未查找到ffmpeg依赖包时崩溃的问题
Bug: https://pms.uniontech.com/bug-view-213565.html
Influence: MovieCover

@rb-union
Copy link
Contributor Author

/review @starhcq

@github-actions github-actions bot requested a review from starhcq September 13, 2023 08:53
@rb-union rb-union force-pushed the fix_213565_crash branch 3 times, most recently from 75c049e to 413b0fc Compare September 15, 2023 08:32
starhcq
starhcq previously approved these changes Sep 18, 2023
Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@rb-union rb-union force-pushed the fix_213565_crash branch 3 times, most recently from 76c0fe0 to 7ae6cd3 Compare September 25, 2023 01:13
软件调整环境变量,可能未查找到库,解析接口时,
遗漏判空处理,导致访问越界;
同时调整创建临时图片的方式,改为 QTemporaryDir 的方式.

Log: 修复未查找到ffmpeg依赖包时崩溃的问题
Bug: https://pms.uniontech.com/bug-view-213565.html
Influence: MovieCover
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 1df2758 into linuxdeepin:master Sep 26, 2023
13 checks passed
@rb-union rb-union deleted the fix_213565_crash branch September 26, 2023 06:18
rb-union added a commit to rb-union/image-editor that referenced this pull request Sep 26, 2023
Bump version to 1.0.36
PR:
* linuxdeepin#93

Log: Bump version to 1.0.36
rb-union added a commit to rb-union/image-editor that referenced this pull request Sep 26, 2023
Bump version to 1.0.37 for community,
previous is 1.0.34
PR:
* linuxdeepin#90
* linuxdeepin#92
* linuxdeepin#93

Log: [ Community ] Bump version to 1.0.37
lzwind pushed a commit that referenced this pull request Sep 26, 2023
Bump version to 1.0.36
PR:
* #93

Log: Bump version to 1.0.36
rb-union added a commit to rb-union/image-editor that referenced this pull request Sep 26, 2023
Bump version to 1.0.37 for community,
previous is 1.0.34
PR:
* linuxdeepin#90
* linuxdeepin#92
* linuxdeepin#93

Log: [ Community ] Bump version to 1.0.37
lzwind pushed a commit that referenced this pull request Sep 26, 2023
Bump version to 1.0.37 for community,
previous is 1.0.34
PR:
* #90
* #92
* #93

Log: [ Community ] Bump version to 1.0.37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants