Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use common method to check the version of dtkwidget #152

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: Use common method to check the version of dtkwidget #152

merged 1 commit into from
Nov 25, 2024

Conversation

hillwoodroc
Copy link
Contributor

Log: Using a special method is not friendly for other distributions

@deepin-ci-robot
Copy link

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BLumia
BLumia requested changes Nov 11, 2024
View reviewed changes
libimageviewer/CMakeLists.txt Outdated Show resolved Hide resolved
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 15, 2024

TAG Bot

New tag: 1.0.47
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #153

wineee
wineee suggested changes Nov 19, 2024
View reviewed changes
libimageviewer/CMakeLists.txt Outdated

if (${DWIDGET_VERSION_STR} VERSION_LESS "5.6.9-1")
message(STATUS "Use specific dtk watermakr, Version < 5.6.9-1")
if (${DWIDGET_VERSION} VERSION_LESS "5.6.9")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是 DtkWidget_VERSION ？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这会应该对了。

@hillwoodroc
fix: Use common method to check the version of dtkwidget
a2485e4 
Log: Using a special method is not friendly for other distributions
@BLumia
Copy link
Member

BLumia commented Nov 19, 2024

/check obs

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 19, 2024 •
edited
Loading

Deepin Obs Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@BLumia BLumia requested a review from rb-union November 19, 2024 13:13
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, hillwoodroc, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit e07f219 into linuxdeepin:master Nov 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wineee wineee wineee approved these changes

@BLumia BLumia BLumia approved these changes

@rb-union rb-union Awaiting requested review from rb-union

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hillwoodroc @deepin-ci-robot @BLumia @wineee