Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add media file information display in property dialog #2532

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

Lighto-Ku
Copy link
Contributor

  • Add support for displaying image size (width x height) for image files
  • Add support for displaying resolution and duration for video files
  • Add support for displaying duration for audio files
  • Add new property filter types and basic field enums for media info
  • Implement media info handling functions for image/video/audio files

This enhancement improves the property dialog by showing more detailed
information for media files, providing better user experience.

Log: Add media file information display in property dialog
Task: https://pms.uniontech.com/story-view-36051.html

- Add support for displaying image size (width x height) for image files
- Add support for displaying resolution and duration for video files
- Add support for displaying duration for audio files
- Add new property filter types and basic field enums for media info
- Implement media info handling functions for image/video/audio files

This enhancement improves the property dialog by showing more detailed
information for media files, providing better user experience.

Log: Add media file information display in property dialog
Task: https://pms.uniontech.com/story-view-36051.html
as title

Log: update translation
Change the config key from "03_restore_view_mode" to "04_restore_view_mode" to
match its path name in LV2_GROUP_VIEW ".04_restore_view_mode", maintaining
consistency in the configuration system.

Log: fix settings issue
Bug: https://pms.uniontech.com/bug-view-298263.html
- Limit filename display height to normal height (2 lines) when item is not
  selected or not a single selection target
- Update Chinese comments to English for better code readability
- Keep maximum height display for the last item when it's single selected
  to ensure proper scrollbar appearance

Log: optimize filename display
Bug: https://pms.uniontech.com/bug-view-298351.html
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. settingbackend.cpp文件中,initWorkspaceSettingConfig函数中修改了配置项的键值,需要确认这个修改是否符合预期,并且相关的配置文件和逻辑是否已经更新。

  2. dfmplugin_propertydialog_global.h文件中,新增了文件属性过滤类型,需要检查这些新增的类型是否已经在相关的代码中得到了正确的处理。

  3. basicwidget.cpp文件中,新增了文件图片大小、媒体分辨率和媒体时长的显示逻辑,需要确保这些新增的逻辑不会对现有的功能产生负面影响,并且相关的UI元素已经正确地初始化。

  4. basicwidget.cpp文件中,basicFill函数中新增了对媒体属性的获取和处理逻辑,需要确认这些逻辑是否正确地处理了媒体文件的信息,并且相关的UI元素已经正确地更新。

  5. basicwidget.h文件中,新增了文件图片大小、媒体分辨率和媒体时长的显示元素,需要确保这些新增的元素已经正确地添加到UI布局中。

  6. iconitemdelegate.cpp文件中,对文件名显示的长度进行了限制,以防止滚动条出现在右侧,需要确认这个修改是否符合UI设计的要求。

  7. dde-file-manager.ts等翻译文件中,新增了一些翻译项,需要确保这些翻译项已经正确地反映了应用程序的功能和界面。

  8. dde-file-manager.ts等翻译文件中,一些翻译项的注释被删除了,需要确认这些注释是否不再需要,或者是否需要保留以供参考。

以上是本次代码提交的审查意见,希望能够帮助到您。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/merge

@deepin-bot deepin-bot bot merged commit e2f7120 into linuxdeepin:master Jan 2, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants