fix bugs #2478
Merged
fix bugs #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
|
1 similar comment
|
Warning
|
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
1 similar comment
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
deepin-compressor is no longer a linglong app! Log: fix bug Bug: https://pms.uniontech.com/bug-view-286519.html
- Add proper scroll bar policy for vertical scrolling - Fix dialog height calculation to respect screen boundaries - Add size policies to maintain proper widget dimensions - Set maximum width for dialog content - Improve height adjustment logic for both Wayland and X11 - Fix content widget resizing and geometry updates Log: fix ui bug Bug: https://pms.uniontech.com/bug-view-287197.html
- Update dbus interface name from com.deepin.filemanager.daemon to org.deepin.Filemanager.MountControl - Update dbus object path accordingly - Add dlnfs package dependency in debian/control This change fixes compatibility issues with the new dlnfs dbus interface naming convention. Log: Bug: https://pms.uniontech.com/bug-view-273567.html
- Move stretch item management to showEvent - Remove redundant stretch item before adding new one - Fix potential memory leak by properly deleting old stretch item This change ensures proper layout spacing in the property dialog and prevents multiple stretch items from being added unintentionally. Log:
- Replace manual symlink and home path check with proper canTrash attribute check - Simplify trash permission validation logic by removing redundant conditions - Use FileInfo's canAttributes API instead of manual path checks - Remove unnecessary supportTrash validation since it's handled by canTrash check This change makes the code more maintainable and follows the proper attribute checking pattern defined in the FileInfo interface. Log:
- Add canonicalUrlList utility to properly handle symlink paths - Preserve symlink's original path while resolving parent directory - Process source URLs before trash operations to ensure correct paths - Handle symlinks in directories that are themselves symlinks This fixes an issue where symlinks would be incorrectly resolved when moving to trash, especially when the symlink is located in a directory that is also a symlink. The new implementation maintains the symlink's identity while ensuring its parent path is properly resolved. Log: fix bug Bug: https://pms.uniontech.com/bug-view-287739.html
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
- Remove unnecessary Conflicts fields since Replaces is sufficient - Remove Conflicts with dde-desktop-plugins as it's already covered by Replaces - Remove duplicate package conflicts that are handled by Replaces - Remove redundant Conflicts with dfmplugin-disk-encrypt The Replaces field already handles package replacement properly, making the Conflicts declarations redundant in these cases. This simplifies the package relationships while maintaining the same functionality. Log:
liyigang1
approved these changes
Dec 9, 2024
deepin pr auto review代码审查意见：
|
|
Warning
|
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 68,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
Clauszy
approved these changes
Dec 9, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Clauszy, Johnson-zs, liyigang1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.