From 9914fb30f8fcde7ffaadf64fee454024a072afc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 5 Aug 2024 15:46:40 +0200 Subject: [PATCH 1/8] http_server: simplify the request handler MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `serve_dir` function already returns a suitable Future, so there is no need to wrap it inside an extra async block. Signed-off-by: Leonard Göhrs --- src/http_server.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/http_server.rs b/src/http_server.rs index 63536e23..3ec83180 100644 --- a/src/http_server.rs +++ b/src/http_server.rs @@ -104,7 +104,7 @@ impl HttpServer { /// Serve a directory from disk for reading fn expose_dir(&mut self, fs_path: &'static str, web_path: &str, directory_listings: bool) { - let handler = move |req| async move { serve_dir(fs_path, directory_listings, req).await }; + let handler = move |req| serve_dir(fs_path, directory_listings, req); self.server.at(web_path).get(handler); self.server.at(web_path).at("").get(handler); From 1e0a7229c9a086ca7a3977a79775b6c1e1f2db6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 5 Aug 2024 15:48:19 +0200 Subject: [PATCH 2/8] http_server: allow forcing a mime type for all files in a directory MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This will come in handy for license files, which do not have an extension that can be used to guess the mime type, but which are known to be plain text. Signed-off-by: Leonard Göhrs --- src/http_server.rs | 14 ++++++++++---- src/http_server/serve_dir.rs | 19 ++++++++++++++----- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/src/http_server.rs b/src/http_server.rs index 3ec83180..9fb0a86f 100644 --- a/src/http_server.rs +++ b/src/http_server.rs @@ -78,8 +78,8 @@ impl HttpServer { ); this.expose_openapi_json(); - this.expose_dir(WEBUI_DIR, "/", false); - this.expose_dir(EXTRA_DIR, "/srv", true); + this.expose_dir(WEBUI_DIR, "/", false, None); + this.expose_dir(EXTRA_DIR, "/srv", true, None); for (fs_path, web_path) in EXPOSED_FILES_RW { let fs_path = FS_PREFIX.to_owned() + *fs_path; @@ -103,8 +103,14 @@ impl HttpServer { } /// Serve a directory from disk for reading - fn expose_dir(&mut self, fs_path: &'static str, web_path: &str, directory_listings: bool) { - let handler = move |req| serve_dir(fs_path, directory_listings, req); + fn expose_dir( + &mut self, + fs_path: &'static str, + web_path: &str, + directory_listings: bool, + force_mime: Option<&'static str>, + ) { + let handler = move |req| serve_dir(req, fs_path, directory_listings, force_mime); self.server.at(web_path).get(handler); self.server.at(web_path).at("").get(handler); diff --git a/src/http_server/serve_dir.rs b/src/http_server/serve_dir.rs index 9073c19f..cbf688e1 100644 --- a/src/http_server/serve_dir.rs +++ b/src/http_server/serve_dir.rs @@ -46,7 +46,7 @@ fn clamp_timestamp(ts: SystemTime) -> SystemTime { max(tacd_build_time, ts) } -async fn file(req: &Request<()>, fs_path: &Path) -> Result { +async fn file(req: &Request<()>, fs_path: &Path, force_mime: Option<&str>) -> Result { // Check the files modification date and compare it to the one provided // by the client (if any) to determine if we even need to send the file. let modification_date = fs_path.metadata()?.modified()?; @@ -109,7 +109,11 @@ async fn file(req: &Request<()>, fs_path: &Path) -> Result { .header("Last-Modified", last_modified) .header("Cache-Control", "max-age=30, must-revalidate"); - let body = Body::from_file(fs_path).await?; + let mut body = Body::from_file(fs_path).await?; + + if let Some(mime) = force_mime { + body.set_mime(mime); + } if have_gz && accept_gz { let mut gz_body = Body::from_file(gz_path.unwrap()).await?; @@ -241,7 +245,12 @@ fn dir_listing(fs_path: &Path, is_root: bool) -> Result { Ok(res) } -pub async fn serve_dir(base_path: &str, directory_listings: bool, req: Request<()>) -> Result { +pub async fn serve_dir( + req: Request<()>, + base_path: &str, + directory_listings: bool, + force_mime: Option<&str>, +) -> Result { let url_path = req.url().path(); let has_trailing_slash = url_path.ends_with('/'); @@ -274,13 +283,13 @@ pub async fn serve_dir(base_path: &str, directory_listings: bool, req: Request<( let res = { if !is_dir { - file(&req, &path).await + file(&req, &path, force_mime).await } else if !has_trailing_slash { redirect_dir(url_path) } else if directory_listings && !has_index { dir_listing(&path, is_root) } else { - file(&req, &index_path).await + file(&req, &index_path, force_mime).await } }; From 4388475bdc2643103e97dcf6968edecf8ec3450b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 5 Aug 2024 15:50:15 +0200 Subject: [PATCH 3/8] http_server: serve license files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some open source license require shipping the license text along with the built software. To comply with this requirement we let yocto generate a directory with license texts inside of it and expose it via the web interface. Signed-off-by: Leonard Göhrs --- .../share/common-licenses/license.manifest | 9 + .../share/licenses/tacd-webinterface/LICENSE | 339 ++++++++++++++++++ demo_files/usr/share/licenses/tacd/LICENSE | 339 ++++++++++++++++++ src/http_server.rs | 12 +- 4 files changed, 698 insertions(+), 1 deletion(-) create mode 100644 demo_files/usr/share/common-licenses/license.manifest create mode 100644 demo_files/usr/share/licenses/tacd-webinterface/LICENSE create mode 100644 demo_files/usr/share/licenses/tacd/LICENSE diff --git a/demo_files/usr/share/common-licenses/license.manifest b/demo_files/usr/share/common-licenses/license.manifest new file mode 100644 index 00000000..693cd0e2 --- /dev/null +++ b/demo_files/usr/share/common-licenses/license.manifest @@ -0,0 +1,9 @@ +PACKAGE NAME: tacd +PACKAGE VERSION: 0.1.0+gitAUTOINC+803b2084b2 +RECIPE NAME: tacd +LICENSE: GPL-2.0-or-later + +PACKAGE NAME: tacd-webinterface +PACKAGE VERSION: 0.1.0+gitAUTOINC+803b2084b2 +RECIPE NAME: tacd-webinterface +LICENSE: GPL-2.0-or-later diff --git a/demo_files/usr/share/licenses/tacd-webinterface/LICENSE b/demo_files/usr/share/licenses/tacd-webinterface/LICENSE new file mode 100644 index 00000000..d159169d --- /dev/null +++ b/demo_files/usr/share/licenses/tacd-webinterface/LICENSE @@ -0,0 +1,339 @@ + GNU GENERAL PUBLIC LICENSE + Version 2, June 1991 + + Copyright (C) 1989, 1991 Free Software Foundation, Inc., + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. + + Preamble + + The licenses for most software are designed to take away your +freedom to share and change it. By contrast, the GNU General Public +License is intended to guarantee your freedom to share and change free +software--to make sure the software is free for all its users. This +General Public License applies to most of the Free Software +Foundation's software and to any other program whose authors commit to +using it. (Some other Free Software Foundation software is covered by +the GNU Lesser General Public License instead.) You can apply it to +your programs, too. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +this service if you wish), that you receive source code or can get it +if you want it, that you can change the software or use pieces of it +in new free programs; and that you know you can do these things. + + To protect your rights, we need to make restrictions that forbid +anyone to deny you these rights or to ask you to surrender the rights. +These restrictions translate to certain responsibilities for you if you +distribute copies of the software, or if you modify it. + + For example, if you distribute copies of such a program, whether +gratis or for a fee, you must give the recipients all the rights that +you have. You must make sure that they, too, receive or can get the +source code. And you must show them these terms so they know their +rights. + + We protect your rights with two steps: (1) copyright the software, and +(2) offer you this license which gives you legal permission to copy, +distribute and/or modify the software. + + Also, for each author's protection and ours, we want to make certain +that everyone understands that there is no warranty for this free +software. If the software is modified by someone else and passed on, we +want its recipients to know that what they have is not the original, so +that any problems introduced by others will not reflect on the original +authors' reputations. + + Finally, any free program is threatened constantly by software +patents. We wish to avoid the danger that redistributors of a free +program will individually obtain patent licenses, in effect making the +program proprietary. To prevent this, we have made it clear that any +patent must be licensed for everyone's free use or not licensed at all. + + The precise terms and conditions for copying, distribution and +modification follow. + + GNU GENERAL PUBLIC LICENSE + TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION + + 0. This License applies to any program or other work which contains +a notice placed by the copyright holder saying it may be distributed +under the terms of this General Public License. The "Program", below, +refers to any such program or work, and a "work based on the Program" +means either the Program or any derivative work under copyright law: +that is to say, a work containing the Program or a portion of it, +either verbatim or with modifications and/or translated into another +language. (Hereinafter, translation is included without limitation in +the term "modification".) Each licensee is addressed as "you". + +Activities other than copying, distribution and modification are not +covered by this License; they are outside its scope. The act of +running the Program is not restricted, and the output from the Program +is covered only if its contents constitute a work based on the +Program (independent of having been made by running the Program). +Whether that is true depends on what the Program does. + + 1. You may copy and distribute verbatim copies of the Program's +source code as you receive it, in any medium, provided that you +conspicuously and appropriately publish on each copy an appropriate +copyright notice and disclaimer of warranty; keep intact all the +notices that refer to this License and to the absence of any warranty; +and give any other recipients of the Program a copy of this License +along with the Program. + +You may charge a fee for the physical act of transferring a copy, and +you may at your option offer warranty protection in exchange for a fee. + + 2. You may modify your copy or copies of the Program or any portion +of it, thus forming a work based on the Program, and copy and +distribute such modifications or work under the terms of Section 1 +above, provided that you also meet all of these conditions: + + a) You must cause the modified files to carry prominent notices + stating that you changed the files and the date of any change. + + b) You must cause any work that you distribute or publish, that in + whole or in part contains or is derived from the Program or any + part thereof, to be licensed as a whole at no charge to all third + parties under the terms of this License. + + c) If the modified program normally reads commands interactively + when run, you must cause it, when started running for such + interactive use in the most ordinary way, to print or display an + announcement including an appropriate copyright notice and a + notice that there is no warranty (or else, saying that you provide + a warranty) and that users may redistribute the program under + these conditions, and telling the user how to view a copy of this + License. (Exception: if the Program itself is interactive but + does not normally print such an announcement, your work based on + the Program is not required to print an announcement.) + +These requirements apply to the modified work as a whole. If +identifiable sections of that work are not derived from the Program, +and can be reasonably considered independent and separate works in +themselves, then this License, and its terms, do not apply to those +sections when you distribute them as separate works. But when you +distribute the same sections as part of a whole which is a work based +on the Program, the distribution of the whole must be on the terms of +this License, whose permissions for other licensees extend to the +entire whole, and thus to each and every part regardless of who wrote it. + +Thus, it is not the intent of this section to claim rights or contest +your rights to work written entirely by you; rather, the intent is to +exercise the right to control the distribution of derivative or +collective works based on the Program. + +In addition, mere aggregation of another work not based on the Program +with the Program (or with a work based on the Program) on a volume of +a storage or distribution medium does not bring the other work under +the scope of this License. + + 3. You may copy and distribute the Program (or a work based on it, +under Section 2) in object code or executable form under the terms of +Sections 1 and 2 above provided that you also do one of the following: + + a) Accompany it with the complete corresponding machine-readable + source code, which must be distributed under the terms of Sections + 1 and 2 above on a medium customarily used for software interchange; or, + + b) Accompany it with a written offer, valid for at least three + years, to give any third party, for a charge no more than your + cost of physically performing source distribution, a complete + machine-readable copy of the corresponding source code, to be + distributed under the terms of Sections 1 and 2 above on a medium + customarily used for software interchange; or, + + c) Accompany it with the information you received as to the offer + to distribute corresponding source code. (This alternative is + allowed only for noncommercial distribution and only if you + received the program in object code or executable form with such + an offer, in accord with Subsection b above.) + +The source code for a work means the preferred form of the work for +making modifications to it. For an executable work, complete source +code means all the source code for all modules it contains, plus any +associated interface definition files, plus the scripts used to +control compilation and installation of the executable. However, as a +special exception, the source code distributed need not include +anything that is normally distributed (in either source or binary +form) with the major components (compiler, kernel, and so on) of the +operating system on which the executable runs, unless that component +itself accompanies the executable. + +If distribution of executable or object code is made by offering +access to copy from a designated place, then offering equivalent +access to copy the source code from the same place counts as +distribution of the source code, even though third parties are not +compelled to copy the source along with the object code. + + 4. You may not copy, modify, sublicense, or distribute the Program +except as expressly provided under this License. Any attempt +otherwise to copy, modify, sublicense or distribute the Program is +void, and will automatically terminate your rights under this License. +However, parties who have received copies, or rights, from you under +this License will not have their licenses terminated so long as such +parties remain in full compliance. + + 5. You are not required to accept this License, since you have not +signed it. However, nothing else grants you permission to modify or +distribute the Program or its derivative works. These actions are +prohibited by law if you do not accept this License. Therefore, by +modifying or distributing the Program (or any work based on the +Program), you indicate your acceptance of this License to do so, and +all its terms and conditions for copying, distributing or modifying +the Program or works based on it. + + 6. Each time you redistribute the Program (or any work based on the +Program), the recipient automatically receives a license from the +original licensor to copy, distribute or modify the Program subject to +these terms and conditions. You may not impose any further +restrictions on the recipients' exercise of the rights granted herein. +You are not responsible for enforcing compliance by third parties to +this License. + + 7. If, as a consequence of a court judgment or allegation of patent +infringement or for any other reason (not limited to patent issues), +conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot +distribute so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you +may not distribute the Program at all. For example, if a patent +license would not permit royalty-free redistribution of the Program by +all those who receive copies directly or indirectly through you, then +the only way you could satisfy both it and this License would be to +refrain entirely from distribution of the Program. + +If any portion of this section is held invalid or unenforceable under +any particular circumstance, the balance of the section is intended to +apply and the section as a whole is intended to apply in other +circumstances. + +It is not the purpose of this section to induce you to infringe any +patents or other property right claims or to contest validity of any +such claims; this section has the sole purpose of protecting the +integrity of the free software distribution system, which is +implemented by public license practices. Many people have made +generous contributions to the wide range of software distributed +through that system in reliance on consistent application of that +system; it is up to the author/donor to decide if he or she is willing +to distribute software through any other system and a licensee cannot +impose that choice. + +This section is intended to make thoroughly clear what is believed to +be a consequence of the rest of this License. + + 8. If the distribution and/or use of the Program is restricted in +certain countries either by patents or by copyrighted interfaces, the +original copyright holder who places the Program under this License +may add an explicit geographical distribution limitation excluding +those countries, so that distribution is permitted only in or among +countries not thus excluded. In such case, this License incorporates +the limitation as if written in the body of this License. + + 9. The Free Software Foundation may publish revised and/or new versions +of the General Public License from time to time. Such new versions will +be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + +Each version is given a distinguishing version number. If the Program +specifies a version number of this License which applies to it and "any +later version", you have the option of following the terms and conditions +either of that version or of any later version published by the Free +Software Foundation. If the Program does not specify a version number of +this License, you may choose any version ever published by the Free Software +Foundation. + + 10. If you wish to incorporate parts of the Program into other free +programs whose distribution conditions are different, write to the author +to ask for permission. For software which is copyrighted by the Free +Software Foundation, write to the Free Software Foundation; we sometimes +make exceptions for this. Our decision will be guided by the two goals +of preserving the free status of all derivatives of our free software and +of promoting the sharing and reuse of software generally. + + NO WARRANTY + + 11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY +FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN +OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES +PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED +OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF +MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS +TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE +PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, +REPAIR OR CORRECTION. + + 12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR +REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, +INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING +OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED +TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY +YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER +PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE +POSSIBILITY OF SUCH DAMAGES. + + END OF TERMS AND CONDITIONS + + How to Apply These Terms to Your New Programs + + If you develop a new program, and you want it to be of the greatest +possible use to the public, the best way to achieve this is to make it +free software which everyone can redistribute and change under these terms. + + To do so, attach the following notices to the program. It is safest +to attach them to the start of each source file to most effectively +convey the exclusion of warranty; and each file should have at least +the "copyright" line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License along + with this program; if not, write to the Free Software Foundation, Inc., + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +Also add information on how to contact you by electronic and paper mail. + +If the program is interactive, make it output a short notice like this +when it starts in an interactive mode: + + Gnomovision version 69, Copyright (C) year name of author + Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'. + This is free software, and you are welcome to redistribute it + under certain conditions; type `show c' for details. + +The hypothetical commands `show w' and `show c' should show the appropriate +parts of the General Public License. Of course, the commands you use may +be called something other than `show w' and `show c'; they could even be +mouse-clicks or menu items--whatever suits your program. + +You should also get your employer (if you work as a programmer) or your +school, if any, to sign a "copyright disclaimer" for the program, if +necessary. Here is a sample; alter the names: + + Yoyodyne, Inc., hereby disclaims all copyright interest in the program + `Gnomovision' (which makes passes at compilers) written by James Hacker. + + , 1 April 1989 + Ty Coon, President of Vice + +This General Public License does not permit incorporating your program into +proprietary programs. If your program is a subroutine library, you may +consider it more useful to permit linking proprietary applications with the +library. If this is what you want to do, use the GNU Lesser General +Public License instead of this License. diff --git a/demo_files/usr/share/licenses/tacd/LICENSE b/demo_files/usr/share/licenses/tacd/LICENSE new file mode 100644 index 00000000..d159169d --- /dev/null +++ b/demo_files/usr/share/licenses/tacd/LICENSE @@ -0,0 +1,339 @@ + GNU GENERAL PUBLIC LICENSE + Version 2, June 1991 + + Copyright (C) 1989, 1991 Free Software Foundation, Inc., + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. + + Preamble + + The licenses for most software are designed to take away your +freedom to share and change it. By contrast, the GNU General Public +License is intended to guarantee your freedom to share and change free +software--to make sure the software is free for all its users. This +General Public License applies to most of the Free Software +Foundation's software and to any other program whose authors commit to +using it. (Some other Free Software Foundation software is covered by +the GNU Lesser General Public License instead.) You can apply it to +your programs, too. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +this service if you wish), that you receive source code or can get it +if you want it, that you can change the software or use pieces of it +in new free programs; and that you know you can do these things. + + To protect your rights, we need to make restrictions that forbid +anyone to deny you these rights or to ask you to surrender the rights. +These restrictions translate to certain responsibilities for you if you +distribute copies of the software, or if you modify it. + + For example, if you distribute copies of such a program, whether +gratis or for a fee, you must give the recipients all the rights that +you have. You must make sure that they, too, receive or can get the +source code. And you must show them these terms so they know their +rights. + + We protect your rights with two steps: (1) copyright the software, and +(2) offer you this license which gives you legal permission to copy, +distribute and/or modify the software. + + Also, for each author's protection and ours, we want to make certain +that everyone understands that there is no warranty for this free +software. If the software is modified by someone else and passed on, we +want its recipients to know that what they have is not the original, so +that any problems introduced by others will not reflect on the original +authors' reputations. + + Finally, any free program is threatened constantly by software +patents. We wish to avoid the danger that redistributors of a free +program will individually obtain patent licenses, in effect making the +program proprietary. To prevent this, we have made it clear that any +patent must be licensed for everyone's free use or not licensed at all. + + The precise terms and conditions for copying, distribution and +modification follow. + + GNU GENERAL PUBLIC LICENSE + TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION + + 0. This License applies to any program or other work which contains +a notice placed by the copyright holder saying it may be distributed +under the terms of this General Public License. The "Program", below, +refers to any such program or work, and a "work based on the Program" +means either the Program or any derivative work under copyright law: +that is to say, a work containing the Program or a portion of it, +either verbatim or with modifications and/or translated into another +language. (Hereinafter, translation is included without limitation in +the term "modification".) Each licensee is addressed as "you". + +Activities other than copying, distribution and modification are not +covered by this License; they are outside its scope. The act of +running the Program is not restricted, and the output from the Program +is covered only if its contents constitute a work based on the +Program (independent of having been made by running the Program). +Whether that is true depends on what the Program does. + + 1. You may copy and distribute verbatim copies of the Program's +source code as you receive it, in any medium, provided that you +conspicuously and appropriately publish on each copy an appropriate +copyright notice and disclaimer of warranty; keep intact all the +notices that refer to this License and to the absence of any warranty; +and give any other recipients of the Program a copy of this License +along with the Program. + +You may charge a fee for the physical act of transferring a copy, and +you may at your option offer warranty protection in exchange for a fee. + + 2. You may modify your copy or copies of the Program or any portion +of it, thus forming a work based on the Program, and copy and +distribute such modifications or work under the terms of Section 1 +above, provided that you also meet all of these conditions: + + a) You must cause the modified files to carry prominent notices + stating that you changed the files and the date of any change. + + b) You must cause any work that you distribute or publish, that in + whole or in part contains or is derived from the Program or any + part thereof, to be licensed as a whole at no charge to all third + parties under the terms of this License. + + c) If the modified program normally reads commands interactively + when run, you must cause it, when started running for such + interactive use in the most ordinary way, to print or display an + announcement including an appropriate copyright notice and a + notice that there is no warranty (or else, saying that you provide + a warranty) and that users may redistribute the program under + these conditions, and telling the user how to view a copy of this + License. (Exception: if the Program itself is interactive but + does not normally print such an announcement, your work based on + the Program is not required to print an announcement.) + +These requirements apply to the modified work as a whole. If +identifiable sections of that work are not derived from the Program, +and can be reasonably considered independent and separate works in +themselves, then this License, and its terms, do not apply to those +sections when you distribute them as separate works. But when you +distribute the same sections as part of a whole which is a work based +on the Program, the distribution of the whole must be on the terms of +this License, whose permissions for other licensees extend to the +entire whole, and thus to each and every part regardless of who wrote it. + +Thus, it is not the intent of this section to claim rights or contest +your rights to work written entirely by you; rather, the intent is to +exercise the right to control the distribution of derivative or +collective works based on the Program. + +In addition, mere aggregation of another work not based on the Program +with the Program (or with a work based on the Program) on a volume of +a storage or distribution medium does not bring the other work under +the scope of this License. + + 3. You may copy and distribute the Program (or a work based on it, +under Section 2) in object code or executable form under the terms of +Sections 1 and 2 above provided that you also do one of the following: + + a) Accompany it with the complete corresponding machine-readable + source code, which must be distributed under the terms of Sections + 1 and 2 above on a medium customarily used for software interchange; or, + + b) Accompany it with a written offer, valid for at least three + years, to give any third party, for a charge no more than your + cost of physically performing source distribution, a complete + machine-readable copy of the corresponding source code, to be + distributed under the terms of Sections 1 and 2 above on a medium + customarily used for software interchange; or, + + c) Accompany it with the information you received as to the offer + to distribute corresponding source code. (This alternative is + allowed only for noncommercial distribution and only if you + received the program in object code or executable form with such + an offer, in accord with Subsection b above.) + +The source code for a work means the preferred form of the work for +making modifications to it. For an executable work, complete source +code means all the source code for all modules it contains, plus any +associated interface definition files, plus the scripts used to +control compilation and installation of the executable. However, as a +special exception, the source code distributed need not include +anything that is normally distributed (in either source or binary +form) with the major components (compiler, kernel, and so on) of the +operating system on which the executable runs, unless that component +itself accompanies the executable. + +If distribution of executable or object code is made by offering +access to copy from a designated place, then offering equivalent +access to copy the source code from the same place counts as +distribution of the source code, even though third parties are not +compelled to copy the source along with the object code. + + 4. You may not copy, modify, sublicense, or distribute the Program +except as expressly provided under this License. Any attempt +otherwise to copy, modify, sublicense or distribute the Program is +void, and will automatically terminate your rights under this License. +However, parties who have received copies, or rights, from you under +this License will not have their licenses terminated so long as such +parties remain in full compliance. + + 5. You are not required to accept this License, since you have not +signed it. However, nothing else grants you permission to modify or +distribute the Program or its derivative works. These actions are +prohibited by law if you do not accept this License. Therefore, by +modifying or distributing the Program (or any work based on the +Program), you indicate your acceptance of this License to do so, and +all its terms and conditions for copying, distributing or modifying +the Program or works based on it. + + 6. Each time you redistribute the Program (or any work based on the +Program), the recipient automatically receives a license from the +original licensor to copy, distribute or modify the Program subject to +these terms and conditions. You may not impose any further +restrictions on the recipients' exercise of the rights granted herein. +You are not responsible for enforcing compliance by third parties to +this License. + + 7. If, as a consequence of a court judgment or allegation of patent +infringement or for any other reason (not limited to patent issues), +conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot +distribute so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you +may not distribute the Program at all. For example, if a patent +license would not permit royalty-free redistribution of the Program by +all those who receive copies directly or indirectly through you, then +the only way you could satisfy both it and this License would be to +refrain entirely from distribution of the Program. + +If any portion of this section is held invalid or unenforceable under +any particular circumstance, the balance of the section is intended to +apply and the section as a whole is intended to apply in other +circumstances. + +It is not the purpose of this section to induce you to infringe any +patents or other property right claims or to contest validity of any +such claims; this section has the sole purpose of protecting the +integrity of the free software distribution system, which is +implemented by public license practices. Many people have made +generous contributions to the wide range of software distributed +through that system in reliance on consistent application of that +system; it is up to the author/donor to decide if he or she is willing +to distribute software through any other system and a licensee cannot +impose that choice. + +This section is intended to make thoroughly clear what is believed to +be a consequence of the rest of this License. + + 8. If the distribution and/or use of the Program is restricted in +certain countries either by patents or by copyrighted interfaces, the +original copyright holder who places the Program under this License +may add an explicit geographical distribution limitation excluding +those countries, so that distribution is permitted only in or among +countries not thus excluded. In such case, this License incorporates +the limitation as if written in the body of this License. + + 9. The Free Software Foundation may publish revised and/or new versions +of the General Public License from time to time. Such new versions will +be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + +Each version is given a distinguishing version number. If the Program +specifies a version number of this License which applies to it and "any +later version", you have the option of following the terms and conditions +either of that version or of any later version published by the Free +Software Foundation. If the Program does not specify a version number of +this License, you may choose any version ever published by the Free Software +Foundation. + + 10. If you wish to incorporate parts of the Program into other free +programs whose distribution conditions are different, write to the author +to ask for permission. For software which is copyrighted by the Free +Software Foundation, write to the Free Software Foundation; we sometimes +make exceptions for this. Our decision will be guided by the two goals +of preserving the free status of all derivatives of our free software and +of promoting the sharing and reuse of software generally. + + NO WARRANTY + + 11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY +FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN +OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES +PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED +OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF +MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS +TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE +PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, +REPAIR OR CORRECTION. + + 12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR +REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, +INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING +OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED +TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY +YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER +PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE +POSSIBILITY OF SUCH DAMAGES. + + END OF TERMS AND CONDITIONS + + How to Apply These Terms to Your New Programs + + If you develop a new program, and you want it to be of the greatest +possible use to the public, the best way to achieve this is to make it +free software which everyone can redistribute and change under these terms. + + To do so, attach the following notices to the program. It is safest +to attach them to the start of each source file to most effectively +convey the exclusion of warranty; and each file should have at least +the "copyright" line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License along + with this program; if not, write to the Free Software Foundation, Inc., + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +Also add information on how to contact you by electronic and paper mail. + +If the program is interactive, make it output a short notice like this +when it starts in an interactive mode: + + Gnomovision version 69, Copyright (C) year name of author + Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'. + This is free software, and you are welcome to redistribute it + under certain conditions; type `show c' for details. + +The hypothetical commands `show w' and `show c' should show the appropriate +parts of the General Public License. Of course, the commands you use may +be called something other than `show w' and `show c'; they could even be +mouse-clicks or menu items--whatever suits your program. + +You should also get your employer (if you work as a programmer) or your +school, if any, to sign a "copyright disclaimer" for the program, if +necessary. Here is a sample; alter the names: + + Yoyodyne, Inc., hereby disclaims all copyright interest in the program + `Gnomovision' (which makes passes at compilers) written by James Hacker. + + , 1 April 1989 + Ty Coon, President of Vice + +This General Public License does not permit incorporating your program into +proprietary programs. If your program is a subroutine library, you may +consider it more useful to permit linking proprietary applications with the +library. If this is what you want to do, use the GNU Lesser General +Public License instead of this License. diff --git a/src/http_server.rs b/src/http_server.rs index 9fb0a86f..7cea3a2e 100644 --- a/src/http_server.rs +++ b/src/http_server.rs @@ -29,6 +29,8 @@ use serve_dir::serve_dir; #[cfg(feature = "demo_mode")] mod consts { pub const WEBUI_DIR: &str = "web/build"; + pub const LICENSE_DIR: &str = "demo_files/usr/share/licenses"; + pub const LICENSE_MANIFEST: &str = "demo_files/usr/share/common-licenses/license.manifest"; pub const EXTRA_DIR: &str = "demo_files/srv/www"; pub const FS_PREFIX: &str = "demo_files"; pub const FALLBACK_PORT: &str = "[::]:8080"; @@ -37,12 +39,14 @@ mod consts { #[cfg(not(feature = "demo_mode"))] mod consts { pub const WEBUI_DIR: &str = "/usr/share/tacd/webui"; + pub const LICENSE_DIR: &str = "/usr/share/licenses"; + pub const LICENSE_MANIFEST: &str = "/usr/share/common-licenses/license.manifest"; pub const EXTRA_DIR: &str = "/srv/www"; pub const FS_PREFIX: &str = ""; pub const FALLBACK_PORT: &str = "[::]:80"; } -use consts::{EXTRA_DIR, FALLBACK_PORT, FS_PREFIX, WEBUI_DIR}; +use consts::{EXTRA_DIR, FALLBACK_PORT, FS_PREFIX, LICENSE_DIR, LICENSE_MANIFEST, WEBUI_DIR}; // openapi.json is generated by build.rs from openapi.yaml const OPENAPI_JSON: &[u8] = include_bytes!(concat!(env!("OUT_DIR"), "/openapi.json")); @@ -80,6 +84,12 @@ impl HttpServer { this.expose_openapi_json(); this.expose_dir(WEBUI_DIR, "/", false, None); this.expose_dir(EXTRA_DIR, "/srv", true, None); + this.expose_dir(LICENSE_DIR, "/docs/legal/files", true, Some("text/plain")); + + this.server + .at("/docs/legal/license.manifest") + .serve_file(LICENSE_MANIFEST) + .unwrap(); for (fs_path, web_path) in EXPOSED_FILES_RW { let fs_path = FS_PREFIX.to_owned() + *fs_path; From 5224a73817b00b893c4893ddd922387b8e856d65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 5 Aug 2024 15:54:13 +0200 Subject: [PATCH 4/8] web: legal: show a list of packages along with their license in the web ui MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Leonard Göhrs --- web/src/App.tsx | 5 +- web/src/LandingPage.tsx | 5 ++ web/src/Legal.tsx | 185 ++++++++++++++++++++++++++++++++++++++++ web/src/index.tsx | 2 + 4 files changed, 196 insertions(+), 1 deletion(-) create mode 100644 web/src/Legal.tsx diff --git a/web/src/App.tsx b/web/src/App.tsx index 95c91ee0..17fec1e0 100644 --- a/web/src/App.tsx +++ b/web/src/App.tsx @@ -98,7 +98,10 @@ function Navigation() { { type: "section", text: "Documentation", - items: [{ type: "link", text: "REST API", href: "#/docs/api" }], + items: [ + { type: "link", text: "REST API", href: "#/docs/api" }, + { type: "link", text: "Legal Information", href: "#/docs/legal" }, + ], }, { type: "section", diff --git a/web/src/LandingPage.tsx b/web/src/LandingPage.tsx index 78202aea..26cdeb17 100644 --- a/web/src/LandingPage.tsx +++ b/web/src/LandingPage.tsx @@ -72,6 +72,11 @@ export default function LandingPage() { href: "/#/docs/api", description: "Find API definitions to automate you LXA TAC", }, + { + name: "Documentation / Legal Information", + href: "/#/docs/legal", + description: "See the software components and their licenses", + }, ]} /> diff --git a/web/src/Legal.tsx b/web/src/Legal.tsx new file mode 100644 index 00000000..3b9b8246 --- /dev/null +++ b/web/src/Legal.tsx @@ -0,0 +1,185 @@ +// This file is part of tacd, the LXA TAC system daemon +// Copyright (C) 2024 Pengutronix e.K. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License along +// with this program; if not, write to the Free Software Foundation, Inc., +// 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +import Container from "@cloudscape-design/components/container"; +import Header from "@cloudscape-design/components/header"; +import Table from "@cloudscape-design/components/table"; +import Link from "@cloudscape-design/components/link"; +import SpaceBetween from "@cloudscape-design/components/space-between"; + +import { useEffect, useState } from "react"; + +type Package = { + package_name: string; + version: string; + recipe_name: string; + license: string; +}; + +function parse_manifest(text: string) { + let packages: Package[] = []; + + // The content of `text` looks something like this: + // + // PACKAGE NAME: tacd + // PACKAGE VERSION: 1.0.0 + // RECIPE NAME: tacd + // LICENSE: GPL-2.0-or-later + // + // PACKAGE NAME: tacd-webinterface + // ... + + for (var group of text.split("\n\n")) { + let pkg: Package = { + package_name: "", + version: "", + recipe_name: "", + license: "", + }; + + for (var line of group.split("\n")) { + if (line.startsWith("PACKAGE NAME: ")) { + pkg.package_name = line.replace("PACKAGE NAME: ", ""); + } + if (line.startsWith("PACKAGE VERSION: ")) { + pkg.version = line.replace("PACKAGE VERSION: ", ""); + } + if (line.startsWith("RECIPE NAME: ")) { + pkg.recipe_name = line.replace("RECIPE NAME: ", ""); + } + if (line.startsWith("LICENSE: ")) { + pkg.license = line.replace("LICENSE: ", ""); + } + } + + if (pkg.package_name && pkg.version && pkg.recipe_name && pkg.license) { + packages.push(pkg); + } + } + + return packages; +} + +function package_table(packages?: Package[]) { + return ( + + Packages + + } + columnDefinitions={[ + { + id: "package_name", + header: "Package Name", + cell: (p) => p.package_name, + }, + { + id: "version", + header: "Version", + cell: (p) => p.version, + }, + { + id: "recipe_name", + header: "Recipe Name", + cell: (p) => p.recipe_name, + }, + { + id: "license", + header: "License", + cell: (p) => ( + {p.license} + ), + }, + ]} + items={packages || []} + loading={packages === undefined} + sortingDisabled + resizableColumns + stickyHeader + trackBy="package_name" + /> + ); +} + +function PackageList() { + const [packages, setPackages] = useState(); + + useEffect(() => { + fetch("/docs/legal/license.manifest").then((response) => { + if (response.ok) { + response.text().then((text) => setPackages(parse_manifest(text))); + } + }); + }, []); + + return package_table(packages); +} + +export default function Legal() { + return ( + +
+ LXA TAC / Legal Information +
+ + + Availability of Source Code + + } + > +

+ The LXA TAC software uses many pieces of free and open source + software. A list of these pieces of software, along with their version + number and their respective software license, is shown below. +

+ +

+ Linux Automation GmbH provides all software components required to + build your own LXA TAC software bundles in the form of a public Yocto + Layer:{" "} + + linux-automation/meta-lxatac + + . +

+ +

+ To comply with the terms of copyleft licenses like the GPL we also + provide copies of their sources, along with the applied patches on our{" "} + + download server + + . +

+
+ + +
+ ); +} diff --git a/web/src/index.tsx b/web/src/index.tsx index d8c93b90..d30c2270 100644 --- a/web/src/index.tsx +++ b/web/src/index.tsx @@ -30,6 +30,7 @@ import DashboardTac from "./DashboardTac"; import LandingPage from "./LandingPage"; import SettingsLabgrid from "./SettingsLabgrid"; import Setup from "./Setup"; +import Legal from "./Legal"; import { useState } from "react"; @@ -53,6 +54,7 @@ function WebUi() { /> } /> } /> + } />y } /> From 369c569b668cfb9c71a5969bcb7273027ea9b529 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 9 Sep 2024 10:27:10 +0200 Subject: [PATCH 5/8] web: legal: test: prepare everything for running tests with jest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The create-react-app project has already prepared everything for us so we can run unit tests on our code base. All that is left to set up are some tweaks so that jest runs babel on the cloudscape dependency, because otherwise the tests will trip over javascript features that are just too new. Signed-off-by: Leonard Göhrs --- web/package.json | 2 +- web/src/Legal.test.ts | 3 +++ web/src/Legal.tsx | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 web/src/Legal.test.ts diff --git a/web/package.json b/web/package.json index f3931c71..c28fa8f7 100644 --- a/web/package.json +++ b/web/package.json @@ -30,7 +30,7 @@ "scripts": { "start": "react-scripts start", "build": "react-scripts build", - "test": "react-scripts test", + "test": "react-scripts test --transformIgnorePatterns \"node_modules/(?!@cloudscape-design)/\"", "eject": "react-scripts eject" }, "eslintConfig": { diff --git a/web/src/Legal.test.ts b/web/src/Legal.test.ts new file mode 100644 index 00000000..c9dc8ea0 --- /dev/null +++ b/web/src/Legal.test.ts @@ -0,0 +1,3 @@ +import { parse_manifest } from "./Legal"; + +it("runs", () => {}); diff --git a/web/src/Legal.tsx b/web/src/Legal.tsx index 3b9b8246..783274bf 100644 --- a/web/src/Legal.tsx +++ b/web/src/Legal.tsx @@ -30,7 +30,7 @@ type Package = { license: string; }; -function parse_manifest(text: string) { +export function parse_manifest(text: string) { let packages: Package[] = []; // The content of `text` looks something like this: From 6a8076a97ec8ae45439cf9409f0ab3fdb8195bd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 9 Sep 2024 10:12:15 +0200 Subject: [PATCH 6/8] web: legal: test: add a manifest file parsing test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test uses the manifest file used in the demo mode as a reference. The file is very minimal, as it only has two entries, but the format is very regular, so how many entries it has should not make much of a difference. Signed-off-by: Leonard Göhrs --- web/src/Legal.test.ts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/web/src/Legal.test.ts b/web/src/Legal.test.ts index c9dc8ea0..587298b3 100644 --- a/web/src/Legal.test.ts +++ b/web/src/Legal.test.ts @@ -1,3 +1,29 @@ +import fs from "node:fs"; + import { parse_manifest } from "./Legal"; -it("runs", () => {}); +const manifest_ref = [ + { + package_name: "tacd", + version: "0.1.0+gitAUTOINC+803b2084b2", + recipe_name: "tacd", + license: "GPL-2.0-or-later", + }, + { + package_name: "tacd-webinterface", + version: "0.1.0+gitAUTOINC+803b2084b2", + recipe_name: "tacd-webinterface", + license: "GPL-2.0-or-later", + }, +]; + +it("parses the manifest", () => { + const manifest_raw = fs.readFileSync( + "../demo_files/usr/share/common-licenses/license.manifest", + "utf-8", + ); + + const manifest = parse_manifest(manifest_raw); + + expect(manifest).toEqual(manifest_ref); +}); From 7c67d6146215cdf80c4e15ac78b29a8e9527a3c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20G=C3=B6hrs?= Date: Mon, 9 Sep 2024 10:22:18 +0200 Subject: [PATCH 7/8] web: legal: test: add a dummy rendering test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test does not check the rendering output, only that it does in fact render without crashing. An actual test would require a deeper understanding of the jsdom DOM mocking than I currently have. Maybe we can add it in the future. Signed-off-by: Leonard Göhrs --- web/src/Legal.test.ts | 12 +++++++++++- web/src/Legal.tsx | 2 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/web/src/Legal.test.ts b/web/src/Legal.test.ts index 587298b3..ef19256a 100644 --- a/web/src/Legal.test.ts +++ b/web/src/Legal.test.ts @@ -1,6 +1,7 @@ import fs from "node:fs"; +import ReactDOM from "react-dom/client"; -import { parse_manifest } from "./Legal"; +import { parse_manifest, package_table } from "./Legal"; const manifest_ref = [ { @@ -27,3 +28,12 @@ it("parses the manifest", () => { expect(manifest).toEqual(manifest_ref); }); + +it("renders", () => { + const div = document.createElement("div"); + const root = ReactDOM.createRoot(div); + + const manifest_table = package_table(manifest_ref); + + root.render(manifest_table); +}); diff --git a/web/src/Legal.tsx b/web/src/Legal.tsx index 783274bf..cc9fde8e 100644 --- a/web/src/Legal.tsx +++ b/web/src/Legal.tsx @@ -74,7 +74,7 @@ export function parse_manifest(text: string) { return packages; } -function package_table(packages?: Package[]) { +export function package_table(packages?: Package[]) { return (
Date: Mon, 9 Sep 2024 10:16:00 +0200 Subject: [PATCH 8/8] CI: tacd-webui: also run npm tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Until now we did not have any tests to run, but that has changed now. Run the new tests in a CI job. Signed-off-by: Leonard Göhrs --- .github/workflows/tacd-webui.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/tacd-webui.yaml b/.github/workflows/tacd-webui.yaml index 09b88930..50f6022a 100644 --- a/.github/workflows/tacd-webui.yaml +++ b/.github/workflows/tacd-webui.yaml @@ -62,3 +62,17 @@ jobs: node-version: latest - run: npm ci - run: npm run build + + test: + name: npm run test + runs-on: ubuntu-latest + defaults: + run: + working-directory: web + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: latest + - run: npm ci + - run: npm run test