Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long option to apfs-label & apfs-snap #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Integral-Tech
Copy link
Contributor

No description provided.

@eafer
Copy link
Member

eafer commented Oct 23, 2024

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

@Integral-Tech
Copy link
Contributor Author

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

Okay, thanks :)

@Integral-Tech
Copy link
Contributor Author

@eafer

@eafer
Copy link
Member

eafer commented Nov 4, 2024

Do you need this to support long options for a particular reason?

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Nov 4, 2024

Do you need this to support long options for a particular reason?

Just because most of Linux commands, including file system user utilities, support --version argument.

@eafer
Copy link
Member

eafer commented Nov 4, 2024

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Nov 5, 2024

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

Btrfs tool has --version option:

╰─❯ btrfs --version
btrfs-progs v6.11
-EXPERIMENTAL -INJECT -STATIC +LZO +ZSTD +UDEV +FSVERITY +ZONED CRYPTO=libgcrypt

@eafer
Copy link
Member

eafer commented Nov 5, 2024

Sure, I know that plenty of other tools have --version. I just meant that it's not universal, so it's not a problem if it's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants