Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something wrong in implementation of SCSE module #19

Open
John1231983 opened this issue Jul 30, 2018 · 1 comment
Open

Something wrong in implementation of SCSE module #19

John1231983 opened this issue Jul 30, 2018 · 1 comment

Comments

@John1231983
Copy link

Hello, thanks for sharing your implementation. I did not understand why do you add 1 in the return of SCSE module

https://github.com/ansleliu/LightNet/blob/04af22501d644b30a93b30b28b32163d60ae2266/modules/misc.py#L110

I think it should be

return (chn_se + spa_se)

Basiclly, the ScSE did as follows: (1) convolution 1x1 x C for channel side and (2) convolution 1x1x1 for spatial size. Then add (1) and (2)

@ryohachiuma
Copy link

The author did not add 1 in the code.
If you want to add two tensors, you should use add module below.

torch.add(input, value=1, other, out=None)

It will calculate input + value * other.
(Ref: https://pytorch.org/docs/stable/torch.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants