Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewdog container image 9082 #99

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reviewdog container image 9082 #99

wants to merge 2 commits into from

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Nov 12, 2024

Types of changes

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types
  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

@mhitza
fix: remove yamllint configuration #9082
8960c97 
Running and checking the yamllint configuration rules https://yamllint.readthedocs.io/en/stable/rules.html
it seems that most of these conflict with autogenerated yaml files files
for symfony and GitHub action workflow specific choices.

It is a simpler choice to remove yamllint from the potential review
steps, than using a very superifical configuration that amounts for a
couple of cases that would be also catched when YAML files are used
(such as strings interpreted as truty values).
@mhitza
feat: initial reviewdog container build #9082
b27f626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhitza