Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Steps: Remove Getting Started panel from Grafana #247

Open
siggy opened this issue Mar 27, 2019 · 0 comments
Open

Add Steps: Remove Getting Started panel from Grafana #247

siggy opened this issue Mar 27, 2019 · 0 comments

Comments

@siggy
Copy link
Member

siggy commented Mar 27, 2019

#245 fixed a build issue in the Add Steps demo by upgrading Grafana. That version bump introduced a "Getting Started" panel in the Grafana dashboard, which should be removed.

Background

Newer versions of Grafana include a "Getting Started" panel that should be disabled for our demo:
Screen Shot 2019-03-26 at 10 13 19 AM

Proposal

Change the anonymous org role from Admin to Editor:

diff --git a/add-steps/docker-compose.yml b/add-steps/docker-compose.yml
index b391b36..5573f71 100644
--- a/add-steps/docker-compose.yml
+++ b/add-steps/docker-compose.yml
@@ -149,7 +149,7 @@ services:
       - 3000:3000
     environment:
       - GF_AUTH_ANONYMOUS_ENABLED=true
-      - GF_AUTH_ANONYMOUS_ORG_ROLE=Admin
+      - GF_AUTH_ANONYMOUS_ORG_ROLE=Editor

   baseline_slow_cooker:
     image: buoyantio/slow_cooker:1.1.0-golang1.8rc2

Note that this breaks our bootstrap.sh script because we can no longer add datasources via the Grafana HTTP API:

$ curl http://localhost:3000/api/datasources
{"message":"Permission denied"}

To address this, add the Prometheus datasource via Datasource provisioning rather than via API. For example:
https://github.com/linkerd/linkerd-viz/blob/c6b4f2baff880ac5c093b6beaec1d42140ce2a48/linkerd-viz#L45-L61

Also bump the Kubernetes version to Grafana 5.4.3:

- image: grafana/grafana:5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant