From b3c57654f0f675ba4b544bc2c8984dd802c7d9d4 Mon Sep 17 00:00:00 2001 From: Kevin Ge Date: Tue, 30 Jan 2024 19:51:42 -0500 Subject: [PATCH 1/4] make java and python build requirement more clear --- README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 59c93bff1..ac8df73d1 100644 --- a/README.md +++ b/README.md @@ -66,12 +66,13 @@ git clone https://github.com/linkedin/coral.git Build: +**Important:** +Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use: + ```bash ./gradlew clean build ``` - -Please note that this project requires Python 3 and Java 8 to run. Either set `JAVA_HOME` to the home of an appropriate version and then use `./gradlew clean build` as described above, or set the `org.gradle.java.home` gradle property to the Java home of an appropriate version as below: - +or, set the `org.gradle.java.home` gradle property to the Java home of an appropriate version as below: ```bash ./gradlew -Dorg.gradle.java.home=/path/to/java/home clean build ``` From 244378f4a35b77f562cee4025a91dd42951f160f Mon Sep 17 00:00:00 2001 From: Kevin Ge Date: Tue, 30 Jan 2024 19:56:36 -0500 Subject: [PATCH 2/4] Update README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index ac8df73d1..10d5590d2 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,6 @@ git clone https://github.com/linkedin/coral.git Build: -**Important:** Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use: ```bash From 7c6c453dea4ef1dad9c0abb55a769394280a6846 Mon Sep 17 00:00:00 2001 From: Kevin Ge Date: Tue, 30 Jan 2024 19:57:31 -0500 Subject: [PATCH 3/4] bold --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 10d5590d2..2d6e1b04b 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ git clone https://github.com/linkedin/coral.git Build: -Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use: +**Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use:** ```bash ./gradlew clean build From 08cda99e03ad5fd45a9d4099729cee911dc4498b Mon Sep 17 00:00:00 2001 From: Kevin Ge Date: Tue, 30 Jan 2024 19:59:16 -0500 Subject: [PATCH 4/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d6e1b04b..a5baf150c 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ git clone https://github.com/linkedin/coral.git Build: -**Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use:** +**Please note that this project requires Python 3 and Java 8 to run.** Set `JAVA_HOME` to the home of an appropriate version and then use: ```bash ./gradlew clean build