Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for I3D and C3D Features and Clarify Validation Splits for ActivityNet Dataset #46

Open
alberto-mate opened this issue Oct 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@alberto-mate
Copy link

Currently, the library only supports Resnet_Glove, CLIP, and CLIP_Slowfast features for the ActivityNet and Charades datasets. However, several papers use other feature types, such as I3D (for Charades-STA) and C3D (for ActivityNet), as noted in Table 2 of the EaTR paper (link to paper). Expanding support to include these features would align with a broader range of existing research.

Additionally, I noticed that for ActivityNet, many works report results on the val_2 split, while here only the val split is provided, which I believe corresponds to val_1. Could you clarify this aspect? How can I access to val_2 split?

Thank you for your efforts in creating this unified framework—it’s much appreciated!

@awkrail
Copy link
Contributor

awkrail commented Oct 30, 2024

@alberto-mate Thank you for your interest.

Currently, the library only supports Resnet_Glove, CLIP, and CLIP_Slowfast features for the ActivityNet and Charades datasets. However, several papers use other feature types, such as I3D (for Charades-STA) and C3D (for ActivityNet), as noted in Table 2 of the EaTR paper (link to paper). Expanding support to include these features would align with a broader range of existing research.

I see. Thank you for your advice.
I will release the trained weights based on I3D and C3D features. Let me take some time to train the models.

Additionally, I noticed that for ActivityNet, many works report results on the val_2 split, while here only the val split is provided, which I believe corresponds to val_1. Could you clarify this aspect? How can I access to val_2 split?

Thanks. Currently, val_2 is not included, but it's easy to implement by creating activitynet_val_release.jsonl based on val_2.json. I will release the val_2 results in the future, so let me take some time.

@alberto-mate
Copy link
Author

Thank you for your previous response!

After implementing your code, I noticed that contrastive_align_loss is missing in models like MomentDETR, QD-DETR, and CG-DETR (reference to original repo). Could you clarify why this was removed and whether it impacts the models' performance?

Thanks for your time!

@awkrail
Copy link
Contributor

awkrail commented Nov 8, 2024

@alberto-mate Hi, thanks. contrastive_align_loss is not True in their train.sh, so the contrastive loss is not computed. I guess that the authors introduced it but the loss did not work. I removed them from our codebase for the refactoring purpose. In addition, removing these losses does not impact the model's performance. For details, see our paper

@awkrail awkrail added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants