Add Adrian Cole to the codeowners for the Brave module #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me contact the organization owner to give the write permission to @codefromthecrypt. |
|
happy to be here! |
jrhee17
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Note: there is also a project based on github actions in case granting write permission becomes an issue:
https://github.com/dyladan/component-owners
|
aw man.. I broke the build! |
I didn't know about it. Let me try that, thanks! |
minwoox
commented
Feb 14, 2024
.github/component-owners.yml
Outdated
| @@ -0,0 +1,8 @@ | |||
| components: | |||
| /: | |||
There was a problem hiding this comment.
/ is used for all:
https://github.com/dyladan/component-owners/blob/main/src/utils.ts#L51
jrhee17
approved these changes
Feb 14, 2024
|
Thanks! Let me try this. 😉 |
jrhee17
pushed a commit
to jrhee17/armeria
that referenced
this pull request
Mar 4, 2024
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Apr 26, 2024
…5458)" This reverts commit 3a1a673. `dyladan/component-owners` re-requests review when a new commit is pushed. The previous approval was reset. The code seems to handle the case though. https://github.com/dyladan/component-owners/blob/cdaadffde64c918909ee081e3fe044b8910f56c2/src/main.ts#L59 I propose to delete the `component-owners` job and until an alternative is found. If there are any changes on Brave modules, we will mention @codefromthecrypt manually and request a review.
ikhoon
added a commit
that referenced
this pull request
Apr 29, 2024
…" (#5643) This reverts commit 3a1a673. `dyladan/component-owners` re-requests review when a new commit is pushed. The previous approval was reset. The code seems to handle the case though. https://github.com/dyladan/component-owners/blob/cdaadffde64c918909ee081e3fe044b8910f56c2/src/main.ts#L59 I propose to delete the `component-owners` job until an alternative is found. If there are any changes to Brave modules, we will mention @codefromthecrypt manually and request a review.
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this pull request
Jun 8, 2024
…5458)" (line#5643) This reverts commit 3a1a673. `dyladan/component-owners` re-requests review when a new commit is pushed. The previous approval was reset. The code seems to handle the case though. https://github.com/dyladan/component-owners/blob/cdaadffde64c918909ee081e3fe044b8910f56c2/src/main.ts#L59 I propose to delete the `component-owners` job until an alternative is found. If there are any changes to Brave modules, we will mention @codefromthecrypt manually and request a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.