Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hifac and ofac values in JP14_getTransform.m #2

Open
jerdra opened this issue Jan 20, 2021 · 1 comment
Open

Wrong hifac and ofac values in JP14_getTransform.m #2

jerdra opened this issue Jan 20, 2021 · 1 comment

Comments

@jerdra
Copy link

jerdra commented Jan 20, 2021

I think there may have been a small mix-up with the oversampling and maximum allowable frequency factor given in func/JP14_getTransform.m

if nargin < 5
		hifac = 8;
	end

	if nargin < 4
		ofac = 1;
	end

Shouldn't the hifac value be set to 1 here? Otherwise the sampling frequencies that are computed in the line below

f = (1/(T*ofac):1/(T*ofac):hifac*N/(2*T)).';

Would exceed the nyquist limit of the sampler. In Power's original code these are swapped (ofac=8, hfac=1)

@lindenmp
Copy link
Owner

Wow, I'm sorry that I missed this! (I have not been monitoring this code base for a while!). Did you manage to the solve the issue? If not, I can go back and look at my code. In any case, there are many other tools around for processing fMRI data that are superior to this code (e.g., https://fmriprep.org/en/stable/), so I would suggest using those if you're seeking to process your own data (but given the age of this issue, i suspect you've already moved on!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants