The rec area seems to reload every time focus is changed

[yoavartzi]

This area seems to refresh every time I switch back from another. Or at least almost every time. It's a bit odd.

[yoavartzi]

Seems to work fine now. So closing

[yoavartzi]

Actually still doing this. Just switch back-and-forth to the browser tab to reproduce

[swh00tw]

Yeah I see same thing. I will prioritize this.

[yoavartzi]

Actually, this is a broader problem. I also see it my profile page:
https://www.recnet.io/yoav

[swh00tw]

Actually, this is a feature of the data fetching library not a bug. This is called refreshing the stale data. There's a case can explain why this mechanism is useful.

Let's say you open two recent tabs in your browser (no matter unconsciously or deliberately). You made a rec in tab 1. And then go to tab 2. If the refetchOnWindowFocus is true (which is the default behavior and the refreshing you observed now), the tab 2 will display the rec you just made. This mechanism actually made the data in multiple tabs in sync and prevent making double recommendations.

Screen.Recording.2024-08-27.at.3.39.20.PM.mov

If we disable this behavior (set refetchOnWindowFocus to false), double recommendations might happen and the browser tabs won't be in sync. Users need to manually refresh the page to make tabs in sync.

Screen.Recording.2024-08-27.at.3.41.29.PM.mov

[swh00tw]

This is a feature of some major data fetching library:

• https://swr.vercel.app/docs/revalidation#revalidate-on-focus
• https://tanstack.com/query/latest/docs/framework/react/guides/window-focus-refetching#window-focus-refetching

[swh00tw]

While I think we should retain the default refreshing behavior, we can actually disable the refreshing at the profile page if you want since, on that page, the data fetching only involves READ operation. The edge case I mentioned above won't happen. And even if multiple tabs aren't in sync, that doesn't really matter and hurts too much (users need to manually refresh the page).

[yoavartzi]

This makes a lot of sense. Let's disable this for readonly pages, but keep it for input pages.

This probably happens more seamlessly in other websites though. Right?

I am worried about the logic for the recommendation entry panel area though. It's really an edge case, but I could be in the entry page in two tabs (after pressing "recommend a paper") and then submit two recs. I don't know what this will cause. Didn't try it.