Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise proof query/insert RPC endpoints to support transfer proofs #439

Closed
1 of 2 tasks
ffranr opened this issue Aug 8, 2023 · 3 comments
Closed
1 of 2 tasks
Assignees

Comments

@ffranr
Copy link
Contributor

ffranr commented Aug 8, 2023

Generalise proof query and insert RPC endpoints such that they support transfer proofs. They currently only support issuance proofs.

The RPC endpoints are called QueryProof and InsertProof.

This change will include storing transfer proofs within the multiverse.

Deliverables:

@ffranr ffranr self-assigned this Aug 8, 2023
@ffranr ffranr added v0.3 and removed needs triage labels Aug 8, 2023
@ffranr ffranr moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Aug 8, 2023
@Roasbeef
Copy link
Member

Roasbeef commented Aug 9, 2023

So right now the RPC interface doesn't make a distinction between them. The only area we gate things is here:

// The outpoint of the final resting place of the asset should match
// the leaf key
//
// TODO(roasbeef): this restrict to issuance
case assetSnapshot.OutPoint != key.MintingOutpoint:
return nil, fmt.Errorf("outpoint mismatch: expected %v, got %v",
key.MintingOutpoint, assetSnapshot.OutPoint)

@ffranr ffranr changed the title Add functionality to register/fetch multiverse transfer proofs Generalise proof query/inset RPC endpoints to support transfer proofs Aug 15, 2023
@ffranr ffranr changed the title Generalise proof query/inset RPC endpoints to support transfer proofs Generalise proof query/insert RPC endpoints to support transfer proofs Aug 15, 2023
@ffranr
Copy link
Contributor Author

ffranr commented Aug 15, 2023

I've renamed this issue and changed the description but the actual work won't deviate from what we've planed for this sprint.

@ffranr
Copy link
Contributor Author

ffranr commented Sep 19, 2023

Addressed here: #473

@ffranr ffranr closed this as completed Sep 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
3 participants