Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: expand basic-price-oracle example so that more advanced testing can be conducted #1256

Open
ZZiigguurraatt opened this issue Dec 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ZZiigguurraatt
Copy link

basic-price-oracle has the asset id, buy rate, and sell rate hard coded into it. So, one needs to re-compile every time they want to test with a new asset and also when the exchange rate changes. This is totally impractical for automated testing where new assets are created every time a new test network is created and it does not allow us to test with volatile exchange rates.

We need some way to adjust these parameters. Maybe it is with command line options, maybe it is with a config file that is automatically reloaded when the file is re-written, maybe it is from another RPC call that accepts new values, maybe it is by allowing the price oracle to be a proxy for other existing exchange rate sources such as https://www.bitstamp.net/api/ticker/btcusd . Maybe it is all of these things.

We also need to be able to change the server listen address so that we can have multiple price oracles running on the same machine at the same time. This would allow us to operate a price oracle for multiple assets without needing to make the basic-price-oracle example support multiple assets. For the same reason, if we do have a config file, we should be able to change the path for the config file as a command line option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant