Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: force Private=false for regular invoices like is done for hold invoices. #1205

Open
ZZiigguurraatt opened this issue Nov 20, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@ZZiigguurraatt
Copy link

At

taproot-assets/rpcserver.go

Lines 7277 to 7279 in 77e8b28

// We set private to false as we don't want to
// add any hop hints other than this one.
Private: false,

we force private to false for hold invoices as we want to ensure that only a single hop hint is provided for a single private taproot assets channel (which overrides any other hop hints that may be defined).

This is not done for regular invoices though and should be so that we don't accidentally also issue route hints for channels and assets that we don't actually want to receive on.

I'm guessing we need to add

iReq.Private=false

after

// Otherwise, we'll make this into a normal invoice.

but I'm not a go programmer, so not sure of the exact syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant