Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Try all channels when adding an invoice and a channel fails because of no inbound policy #1196

Open
ziggie1984 opened this issue Nov 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ziggie1984
Copy link

When multiple channels exist for the same peer with the same asset_id, we attempt the first channel. However, if it fails due to the absence of an inbound policy, we stop further attempts.

We fetch the channels here:

assetChan, err := r.rfqChannel(ctx, assetID, peerPubKey)

We successfully fetch the first result, but if a downstream failure occurs due to the absence of an inbound channel policy for a particular channel, all other channels of the same peer become unusable until the problematic channel is closed.

inboundPolicy, err := r.getInboundPolicy(

Expected behaviour:

Try all available channels before reporting an error.

@Roasbeef
Copy link
Member

Duplicate of #1052?

@ziggie1984
Copy link
Author

Similar, 1052 wants to even allow more than 1 peer, but this Issue just relates to the fact if we have more than 1 channel witth the same peer, and the first selected has no policy, we will abort and have no ability to use the other channels with the peer (which might have a policy in place)

@ZZiigguurraatt
Copy link

Is there ever going to be a case where there will be a different quote/rate on different channels from the same peer? Wondering in that case if similar prioritization logic as is suggested in #1052 should be considered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants