From 05fc8781916ce4614ed82753ceb4aced773b250f Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Thu, 7 Nov 2024 10:20:11 +0100 Subject: [PATCH 1/2] config: disable internal GRPC logger by default The GRPC connection logger is very verbose and normally not very useful. So it leads to more confusion and unnecessary log bloat than it actually helps to debug things. So we disable it by default, meaning that if GRPC= doesn't appear in the log level config string, we add GRPC=off. That means we can still manually turn it on by adding ,GRPC=info to the log config (e.g. --lnd.debuglevel=debug,GRPC=info). --- config.go | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/config.go b/config.go index 6ad3c2f82..1c478b75e 100644 --- a/config.go +++ b/config.go @@ -386,15 +386,19 @@ func loadAndValidateConfig(interceptor signal.Interceptor) (*Config, error) { // the debug log level(s). In remote lnd mode we have a global log level // that overwrites all others. In integrated mode we use the lnd log // level as the master level. + debuglevel := cfg.Lnd.DebugLevel if cfg.lndRemote { - err = build.ParseAndSetDebugLevels( - cfg.Remote.LitDebugLevel, cfg.Lnd.LogWriter, - ) - } else { - err = build.ParseAndSetDebugLevels( - cfg.Lnd.DebugLevel, cfg.Lnd.LogWriter, - ) + debuglevel = cfg.Remote.LitDebugLevel } + + // By default, we don't want the GRPC connection-level logger to be + // turned on. So if it isn't specifically mentioned in the debug level + // string, we'll disable it. + if !strings.Contains(debuglevel, GrpcLogSubsystem) { + debuglevel += fmt.Sprintf(",%s=off", GrpcLogSubsystem) + } + + err = build.ParseAndSetDebugLevels(debuglevel, cfg.Lnd.LogWriter) if err != nil { return nil, err } From 95e289c6fa5b8dfd8f42be9ef6704b5dd0a327df Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Fri, 8 Nov 2024 09:15:58 +0100 Subject: [PATCH 2/2] docs: add release notes --- docs/release-notes/release-notes-0.13.7.md | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 docs/release-notes/release-notes-0.13.7.md diff --git a/docs/release-notes/release-notes-0.13.7.md b/docs/release-notes/release-notes-0.13.7.md new file mode 100644 index 000000000..4a983ada8 --- /dev/null +++ b/docs/release-notes/release-notes-0.13.7.md @@ -0,0 +1,42 @@ +# Release Notes + +- [Lightning Terminal](#lightning-terminal) + - [Bug Fixes](#bug-fixes) + - [Functional Changes/Additions](#functional-changesadditions) + - [Technical and Architectural Updates](#technical-and-architectural-updates) +- [Integrated Binary Updates](#integrated-binary-updates) + - [LND](#lnd) + - [Loop](#loop) + - [Pool](#pool) + - [Faraday](#faraday) + - [Taproot Assets](#taproot-assets) +- [Contributors](#contributors-alphabetical-order) + +## Lightning Terminal + +### Bug Fixes + +* [Disable the `GRPC` internal low-level connection logger by + default](https://github.com/lightninglabs/lightning-terminal/pull/896). + It can still be enabled by adding `,GRPC=info` at the end of the + `lnd.debuglevel` or `remote.lit-debuglevel` configuration options. + +### Functional Changes/Additions + +### Technical and Architectural Updates + +## Integrated Binary Updates + +### LND + +### Loop + +### Pool + +### Faraday + +### Taproot Assets + +# Contributors (Alphabetical Order) + +- Oliver Gugger \ No newline at end of file