Implement Writeable and Readable for bitcoin::Address

[jbesraa]

As part of lightningdevkit/ldk-node#295 we would like to include address property in the following Events (https://github.com/lightningdevkit/ldk-node/pull/295/files#diff-14da7c350de5742eaa248de110fefeae9b4b639c0358e26024d6040ccf174a41R145).
This require implementing ser::Writeable and ser::Readable for bitcoin::Address

[tnull]

As mentioned over at the LDK Node PR, it was discussed that we'll likely use the receiver's PublicKey instead of an Address. Closing this for now, feel free if there is further need for discussion.

[jbesraa]

I am not entirely sure what the developer or the end user can do with the pubkey? none of the parties are really aware of it as they do not interact with URI, beside scanning the QR code. We can leave the Payjoin events as they are, without the receiver address/pubkey. But I think it is important to show who the user sent the transaction to, so maybe adding the receiver address to the PaymentStore can solve this?

[tnull]

I am not entirely sure what the developer or the end user can do with the pubkey? none of the parties are really aware of it as they do not interact with URI, beside scanning the QR code. We can leave the Payjoin events as they are, without the receiver address/pubkey. But I think it is important to show who the user sent the transaction to, so maybe adding the receiver address to the PaymentStore can solve this?

Ah, excuse the premature closure then, I didn't realize there was still a difference of opinions here. I think we should sync with @DanGould to work out what would be the best API to identify the full end-to-end flow as well as the receiver, as IMO it would be preferable if such identifiers would be provided by and documented in the rust-payjoin APIs, so that users would have uniform/compatible payjoin APIs across implementations, not only for the particular LDK Node one?

[TheBlueMatt]

Is there any conclusion on how this looks in ldk-node?

[jbesraa]

I think no final decision yet, buy will close this for now and reopen if it is needed