Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeysManager link #226

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

mattoshibtc
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for lightningdevkit ready!

Name Link
🔨 Latest commit 35c6773
🔍 Latest deploy log https://app.netlify.com/sites/lightningdevkit/deploys/64f9470b594f420008bc4d2b
😎 Deploy Preview https://deploy-preview-226--lightningdevkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

A quick grep shows that there are quite a few more places that still mention the keysinterface module. Do you mind updating them in this PR as well?

@mattoshibtc
Copy link
Contributor Author

Makes sense, thanks!

A quick grep shows that there are quite a few more places that still mention the keysinterface module. Do you mind updating them in this PR as well?

I tried to replace the clear module references. I see two other 'keysinterface' string matches that I didn't change but are worth pointing out i think,

  1. If you are not using `KeysManager` for keys generation, you must re-derive the private keys yourself. Any `ChannelSigner` object must provide a unique id via the `channel_keys_id` function, whose value is provided back to you in the `SpendableOutputs` objects. A `SpendableOutputDescriptor::StaticOutput` element does not have this information as the output is sent to an output which used only `KeysInterface` data, not per-channel data.

    and
  2. also a few as_KeysInterface() java code examples.

@tnull
Copy link
Contributor

tnull commented Sep 11, 2023

Makes sense, thanks!
A quick grep shows that there are quite a few more places that still mention the keysinterface module. Do you mind updating them in this PR as well?

I tried to replace the clear module references. I see two other 'keysinterface' string matches that I didn't change but are worth pointing out i think,

  1. If you are not using `KeysManager` for keys generation, you must re-derive the private keys yourself. Any `ChannelSigner` object must provide a unique id via the `channel_keys_id` function, whose value is provided back to you in the `SpendableOutputs` objects. A `SpendableOutputDescriptor::StaticOutput` element does not have this information as the output is sent to an output which used only `KeysInterface` data, not per-channel data.

    and

  2. also a few as_KeysInterface() java code examples.

Yeah, these can probably be changed in a separate PR, thanks! Now tracking here: #229.

@ConorOkus ConorOkus merged commit 1453ca8 into lightningdevkit:main Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants