Add implementation for UpdateChannelConfig Api. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
changed the title
jkczyz
reviewed
Oct 18, 2024
jkczyz
reviewed
Oct 21, 2024
Comment on lines
+17
to
+23
| //FIXME: Use ldk/ldk-node's partial config update api. | ||
| let current_config = node | ||
| .list_channels() | ||
| .into_iter() | ||
| .find(|c| c.user_channel_id.0 == user_channel_id) | ||
| .ok_or_else(|| ldk_node::NodeError::InvalidChannelId)? | ||
| .config; |
There was a problem hiding this comment.
Afaiu, Currently there is no api in ldk-node for partial config update, this will have to wait until next ldk-node release.
Since the functionality/user-interface here is equivalent, I don't think there is much point in waiting till then.
Created: lightningdevkit/ldk-node#385
We can remove this once that is complete.
jkczyz
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15