Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses the Overlay component for ClayModal #5221

Open
matuzalemsteles opened this issue Nov 30, 2022 · 1 comment
Open

Uses the Overlay component for ClayModal #5221

matuzalemsteles opened this issue Nov 30, 2022 · 1 comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@matuzalemsteles
Copy link
Member

As part of PR #5208, adds a new Overlay component that better handles a focus trap system and click outside the element, this has greatly reduced the duplicate code we have to solve the same problems in other Clay components.

The goal here is to remove the focus lock implementation that exists inside ClayModal and also the suppression of elements outside the modal in favor of using only Overlay. This will make maintenance a lot easier and ensure consistency of behavior and also accessibility improvements for all overlay related components.

@matuzalemsteles matuzalemsteles added type: enhancement Issues that are open to bring improvements or refinement of code comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Nov 30, 2022
@matuzalemsteles
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Development

No branches or pull requests

1 participant