Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct validators data in VEBO tests #265

Open
Psirex opened this issue Oct 8, 2024 · 0 comments
Open

Correct validators data in VEBO tests #265

Psirex opened this issue Oct 8, 2024 · 0 comments

Comments

@Psirex
Copy link
Contributor

Psirex commented Oct 8, 2024

Here is an improved and corrected version of the text:

  • In the tests for the validator exit bus, the commonly used getLastRequestedValidatorIndices() method does not handle cases where it returns -1. It is recommended to add an assert() to ensure that the returned value is not equal to -1. For instance, the check should be added in this example: test_veb_negative.py, Line 229.

  • In some tests where a LidoValidator is created, an incorrect (validator_key, validator_id) pair is used. This can cause issues during test execution. An example of this can be found here: test_validator_exit_bus_happy_path.py, Line 86.

@Psirex Psirex mentioned this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant